Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Issue 1846073002: Use wildcards for too-long suppressions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance_expectations.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
index 0a243d05c0b4fa408965c2c9af29b4298631fa49..9aa36e715fa46f812c8fa769d7646ae2fde541d3 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os
-import platform
from gpu_tests.gpu_test_expectations import GpuTestExpectations
@@ -26,14 +25,8 @@ class WebGLConformanceExpectations(GpuTestExpectations):
if not '*' in pattern:
full_path = os.path.normpath(os.path.join(self.conformance_path, pattern))
if not os.path.exists(full_path):
- err_msg = ('The WebGL conformance test path specified in ' +
+ raise Exception('The WebGL conformance test path specified in ' +
'expectation does not exist: ' + full_path)
- # Seeing problems on some Windows bots where the full path doesn't
- # seem to exist if it's over 255 characters. http://crbug.com/599333
- if platform.system().startswith('Windows') and len(full_path) > 255:
- print err_msg
- else:
- raise Exception(err_msg)
def SetExpectations(self):
# Fails on all platforms
« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698