Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 1846063002: - Fix the hash code for raw objects that are added into the object pool (Closed)

Created:
4 years, 8 months ago by siva
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix the hash code for raw objects that are added into the object pool index table - Do not try to figure out if the passed in handle is a temporary scoped handle, instead have all the callers create a ZoneHandle Compilation of the ESS initialization code in GreenTea reduces from 2.56secs to .497 secs R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/4b38c3dfc253aba0908611d8026a2151a78d9e9b

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -67 lines) Patch
M runtime/vm/assembler.h View 1 2 chunks +8 lines, -24 lines 0 comments Download
M runtime/vm/assembler.cc View 1 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 8 chunks +22 lines, -21 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
siva
4 years, 8 months ago (2016-03-31 22:30:14 UTC) #2
siva
Updated CL.
4 years, 8 months ago (2016-03-31 23:10:04 UTC) #4
Florian Schneider
lgtm
4 years, 8 months ago (2016-03-31 23:28:52 UTC) #5
siva
Committed patchset #2 (id:20001) manually as 4b38c3dfc253aba0908611d8026a2151a78d9e9b (presubmit successful).
4 years, 8 months ago (2016-04-01 04:41:25 UTC) #7
kasperl
4 years, 8 months ago (2016-04-01 07:11:24 UTC) #9
Message was sent while issue was closed.
Awesome progress!

Powered by Google App Engine
This is Rietveld 408576698