cc : Make CallFunctionForSubtree on impl use layer iterator

cc : Make CallFunctionForSubtree on impl use layer iterator

BUG=568817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/13c050628a5c88ffde430f633ff7e2ac37f52175
Cr-Commit-Position: refs/heads/master@{#384630}

[jaydasika, 2016-03-31 22:04:03]

Description was changed from

==========
cc : Make CallFunctionForSubtree on impl use layer iterator

BUG=568817
==========

to

==========
cc : Make CallFunctionForSubtree on impl use layer iterator

BUG=568817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-31 22:05:47]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-03-31 22:05:47]

PTAL

[ajuma, 2016-03-31 23:11:06]

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common.h (right):

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common.h:139: static void
CallFunctionForEveryLayer(Layer* layer, const Function& function);
Can this take a LayerTreeHost instead? Since this no longer has "Subtree" in its
name, making it take a layer seems confusing.

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common.h:142: static void
CallFunctionForEveryLayer(LayerImpl* layer,
This should take a LayerTreeImpl instead of a LayerImpl.

[jaydasika, 2016-04-01 01:29:59]

had to flip the dependency between LayerTreeHost and LayerTreeHostCommon to
address the comments.

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common.h (right):

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common.h:139: static void
CallFunctionForEveryLayer(Layer* layer, const Function& function);
On 2016/03/31 23:11:06, ajuma wrote:
> Can this take a LayerTreeHost instead? Since this no longer has "Subtree" in
its
> name, making it take a layer seems confusing.

Done.

https://codereview.chromium.org/1846043002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common.h:142: static void
CallFunctionForEveryLayer(LayerImpl* layer,
On 2016/03/31 23:11:06, ajuma wrote:
> This should take a LayerTreeImpl instead of a LayerImpl.

Done.

[ajuma, 2016-04-01 13:38:14]

https://codereview.chromium.org/1846043002/diff/40001/cc/debug/debug_rect_his...
File cc/debug/debug_rect_history.cc (right):

https://codereview.chromium.org/1846043002/diff/40001/cc/debug/debug_rect_his...
cc/debug/debug_rect_history.cc:160: void
DebugRectHistory::SaveTouchEventHandlerRects(LayerImpl* layer) {
Can this be changed to take a tree instead of a layer? Now we're implicitly
assuming it's only ever called on the root layer (which it is), but it'd be good
to make it explicit that this affects the entire tree. Same comment for the
other methods below.

[jaydasika, 2016-04-01 16:48:13]

Patchset #4 (id:60001) has been deleted

[jaydasika, 2016-04-01 17:01:24]

https://codereview.chromium.org/1846043002/diff/40001/cc/debug/debug_rect_his...
File cc/debug/debug_rect_history.cc (right):

https://codereview.chromium.org/1846043002/diff/40001/cc/debug/debug_rect_his...
cc/debug/debug_rect_history.cc:160: void
DebugRectHistory::SaveTouchEventHandlerRects(LayerImpl* layer) {
On 2016/04/01 13:38:14, ajuma wrote:
> Can this be changed to take a tree instead of a layer? Now we're implicitly
> assuming it's only ever called on the root layer (which it is), but it'd be
good
> to make it explicit that this affects the entire tree. Same comment for the
> other methods below.

Done.

[ajuma, 2016-04-01 17:19:29]

Thanks, lgtm

[jaydasika, 2016-04-01 17:22:07]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-04-01 17:22:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846043002/80001

[commit-bot: I haz the power, 2016-04-01 18:12:37]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-01 18:14:04]

Description was changed from

==========
cc : Make CallFunctionForSubtree on impl use layer iterator

BUG=568817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Make CallFunctionForSubtree on impl use layer iterator

BUG=568817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/13c050628a5c88ffde430f633ff7e2ac37f52175
Cr-Commit-Position: refs/heads/master@{#384630}
==========

[commit-bot: I haz the power, 2016-04-01 18:14:07]

Patchset 4 (id:??) landed as
https://crrev.com/13c050628a5c88ffde430f633ff7e2ac37f52175
Cr-Commit-Position: refs/heads/master@{#384630}