cc : Make CallFunctionForSubtree on impl use layer iterator

cc/debug/debug_rect_history.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/debug/debug_rect_history.h"
 
 #include <stddef.h>
 
 #include "cc/base/math_util.h"
 #include "cc/layers/layer_impl.h"
@@ skipping 139 matching lines @@
     if (render_surface_layer->replica_layer()) {
       debug_rects_.push_back(
           DebugRect(REPLICA_SCREEN_SPACE_RECT_TYPE,
                     MathUtil::MapEnclosingClippedRect(
                         render_surface->replica_screen_space_transform(),
                         render_surface->content_rect())));
     }
   }
 }
 
 void DebugRectHistory::SaveTouchEventHandlerRects(LayerImpl* layer) {

[ajuma, 2016/04/01 13:38:14]

Can this be changed to take a tree instead of a layer? Now we're implicitly
assuming it's only ever called on the root layer (which it is), but it'd be good
to make it explicit that this affects the entire tree. Same comment for the
other methods below.

[jaydasika, 2016/04/01 17:01:24]

Done.

-  LayerTreeHostCommon::CallFunctionForSubtree(layer, [this](LayerImpl* layer) {
-    SaveTouchEventHandlerRectsCallback(layer);
-  });
+  LayerTreeHostCommon::CallFunctionForEveryLayer(
+      layer->layer_tree_impl(),
+      [this](LayerImpl* layer) { SaveTouchEventHandlerRectsCallback(layer); });
 }
 
 void DebugRectHistory::SaveTouchEventHandlerRectsCallback(LayerImpl* layer) {
   for (Region::Iterator iter(layer->touch_event_handler_region());
        iter.has_rect();
        iter.next()) {
     debug_rects_.push_back(
         DebugRect(TOUCH_EVENT_HANDLER_RECT_TYPE,
                   MathUtil::MapEnclosingClippedRect(
                       layer->ScreenSpaceTransform(), iter.rect())));
@@ skipping 16 matching lines @@
       root_layer->layer_tree_impl()->InnerViewportScrollLayer();
   if (!inner_viewport)
     return;
   debug_rects_.push_back(DebugRect(
       WHEEL_EVENT_HANDLER_RECT_TYPE,
       MathUtil::MapEnclosingClippedRect(inner_viewport->ScreenSpaceTransform(),
                                         gfx::Rect(inner_viewport->bounds()))));
 }
 
 void DebugRectHistory::SaveScrollEventHandlerRects(LayerImpl* layer) {
-  LayerTreeHostCommon::CallFunctionForSubtree(layer, [this](LayerImpl* layer) {
-    SaveScrollEventHandlerRectsCallback(layer);
-  });
+  LayerTreeHostCommon::CallFunctionForEveryLayer(
+      layer->layer_tree_impl(),
+      [this](LayerImpl* layer) { SaveScrollEventHandlerRectsCallback(layer); });
 }
 
 void DebugRectHistory::SaveScrollEventHandlerRectsCallback(LayerImpl* layer) {
   if (!layer->layer_tree_impl()->have_scroll_event_handlers())
     return;
 
   debug_rects_.push_back(
       DebugRect(SCROLL_EVENT_HANDLER_RECT_TYPE,
                 MathUtil::MapEnclosingClippedRect(layer->ScreenSpaceTransform(),
                                                   gfx::Rect(layer->bounds()))));
 }
 
 void DebugRectHistory::SaveNonFastScrollableRects(LayerImpl* layer) {
-  LayerTreeHostCommon::CallFunctionForSubtree(layer, [this](LayerImpl* layer) {
-    SaveNonFastScrollableRectsCallback(layer);
-  });
+  LayerTreeHostCommon::CallFunctionForEveryLayer(
+      layer->layer_tree_impl(),
+      [this](LayerImpl* layer) { SaveNonFastScrollableRectsCallback(layer); });
 }
 
 void DebugRectHistory::SaveNonFastScrollableRectsCallback(LayerImpl* layer) {
   for (Region::Iterator iter(layer->non_fast_scrollable_region());
        iter.has_rect();
        iter.next()) {
     debug_rects_.push_back(
         DebugRect(NON_FAST_SCROLLABLE_RECT_TYPE,
                   MathUtil::MapEnclosingClippedRect(
                       layer->ScreenSpaceTransform(), iter.rect())));
@@ skipping 17 matching lines @@
     debug_rects_.push_back(
         DebugRect(ANIMATION_BOUNDS_RECT_TYPE,
                   gfx::ToEnclosingRect(gfx::RectF(inflated_bounds.x(),
                                                   inflated_bounds.y(),
                                                   inflated_bounds.width(),
                                                   inflated_bounds.height()))));
   }
 }
 
 }  // namespace cc