Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
184583008:
Fix IWYU in base/files/file.h (Closed)
|
Created:
6 years, 9 months ago by Thiemo Nagel Modified:
6 years, 9 months ago CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix IWYU in base/files/file.h
The other changes follow from that.
BUG=82098
TBR=haruki@chromium.org (for chrome/browser/chromeos/drive/drive_file_system_util.h)
TBR=hidehiko@chromium.org (for chrome/browser/chromeos/drive/webkit_file_stream_writer_impl.h)
TBR=noamsml@chromium.org (for chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache_unittest.cc)
TBR=rvargas@chromium.org (for device/hid/hid_connection_linux.cc)
TBR=clamy@chromium.org (for net/disk_cache/simple/simple_test_util.cc)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255841
Patch Set 1 : #
Total comments: 3
Patch Set 2 : Remove commented-out #include #Patch Set 3 : Rebase #
Messages
Total messages: 45 (0 generated)
Hi Darin, could you please take a look at this IWYU fix? Thank you! Thiemo
Hi Nico, could you please take a look at this IWYU fix? I'm aiming for owner approval in base/files/file.h only -- the remaining changes follow from that and the authors of the relevant lines will be notified via TBR. Thank you! Thiemo
https://codereview.chromium.org/184583008/diff/10002/base/files/file.h File base/files/file.h (right): https://codereview.chromium.org/184583008/diff/10002/base/files/file.h#newcode15 base/files/file.h:15: //#include "base/files/file_path.h" ?
https://codereview.chromium.org/184583008/diff/10002/base/files/file.h File base/files/file.h (right): https://codereview.chromium.org/184583008/diff/10002/base/files/file.h#newcode15 base/files/file.h:15: //#include "base/files/file_path.h" On 2014/03/07 15:30:25, Nico wrote: > ? lgtm with this line removed instead of commented out
https://codereview.chromium.org/184583008/diff/10002/base/files/file.h File base/files/file.h (right): https://codereview.chromium.org/184583008/diff/10002/base/files/file.h#newcode15 base/files/file.h:15: //#include "base/files/file_path.h" On 2014/03/07 15:32:01, Nico wrote: > On 2014/03/07 15:30:25, Nico wrote: > > ? > > lgtm with this line removed instead of commented out Thank you for catching this! I had commented this out for testing and it was an oversight to leave it there for the commit.
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/160001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for net/disk_cache/flash/storage.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: net/disk_cache/flash/storage.h
|diff --git a/net/disk_cache/flash/storage.h b/net/disk_cache/flash/storage.h
|index
d875506efb04f33883c7572177efc9f0501e6492..241d3d88ed30617fbac11b79b4000a3cb2f75fb5
100644
|--- a/net/disk_cache/flash/storage.h
|+++ b/net/disk_cache/flash/storage.h
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
Patch: net/disk_cache/flash/storage.h
Index: net/disk_cache/flash/storage.h
diff --git a/net/disk_cache/flash/storage.h b/net/disk_cache/flash/storage.h
index
d875506efb04f33883c7572177efc9f0501e6492..241d3d88ed30617fbac11b79b4000a3cb2f75fb5
100644
--- a/net/disk_cache/flash/storage.h
+++ b/net/disk_cache/flash/storage.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/files/file.h"
+#include "base/files/file_path.h"
#include "net/base/net_export.h"
namespace disk_cache {
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/184583008/180001
Message was sent while issue was closed.
Change committed as 255841 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
