Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: base/files/file.h

Issue 184583008: Fix IWYU in base/files/file.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/file_system_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_FILES_FILE_H_ 5 #ifndef BASE_FILES_FILE_H_
6 #define BASE_FILES_FILE_H_ 6 #define BASE_FILES_FILE_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include <windows.h> 10 #include <windows.h>
11 #endif 11 #endif
12 12
13 #include <string>
14
15 #include "base/base_export.h" 13 #include "base/base_export.h"
16 #include "base/basictypes.h" 14 #include "base/basictypes.h"
17 #include "base/files/file_path.h" 15 //#include "base/files/file_path.h"
Nico 2014/03/07 15:30:25 ?
Nico 2014/03/07 15:32:01 lgtm with this line removed instead of commented o
Thiemo Nagel 2014/03/07 16:07:38 Thank you for catching this! I had commented this
18 #include "base/move.h" 16 #include "base/move.h"
19 #include "base/time/time.h" 17 #include "base/time/time.h"
20 18
21 #if defined(OS_WIN) 19 #if defined(OS_WIN)
22 #include "base/win/scoped_handle.h" 20 #include "base/win/scoped_handle.h"
23 #endif 21 #endif
24 22
25 namespace base { 23 namespace base {
26 24
25 class FilePath;
26
27 #if defined(OS_WIN) 27 #if defined(OS_WIN)
28 typedef HANDLE PlatformFile; 28 typedef HANDLE PlatformFile;
29 #elif defined(OS_POSIX) 29 #elif defined(OS_POSIX)
30 typedef int PlatformFile; 30 typedef int PlatformFile;
31 #endif 31 #endif
32 32
33 33
34 // Thin wrapper around an OS-level file. 34 // Thin wrapper around an OS-level file.
35 // Note that this class does not provide any support for asynchronous IO, other 35 // Note that this class does not provide any support for asynchronous IO, other
36 // than the ability to create asynchronous handles on Windows. 36 // than the ability to create asynchronous handles on Windows.
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 #endif 281 #endif
282 282
283 Error error_details_; 283 Error error_details_;
284 bool created_; 284 bool created_;
285 bool async_; 285 bool async_;
286 }; 286 };
287 287
288 } // namespace base 288 } // namespace base
289 289
290 #endif // BASE_FILES_FILE_H_ 290 #endif // BASE_FILES_FILE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/file_system_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698