Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1845813002: Suspected fix for a tab image caching bug. (Closed)

Created:
4 years, 8 months ago by Peter Kasting
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suspected fix for a tab image caching bug. If we cache the same image for guest and incognito tabs, but they use different themes, we'll have drawing glitches. I can't reproduce the original problem, so I'm going to try landing this and see if the reporter sees things clear up. BUG=599077 TEST=See bug TBR=estade Committed: https://crrev.com/3044c21c2c8dadd5531258238b8befe6e1ff21fb Cr-Commit-Position: refs/heads/master@{#384210}

Patch Set 1 #

Patch Set 2 : Simpler comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip_controller.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Peter Kasting
In the interests of getting something back to the testers they can try to verify ...
4 years, 8 months ago (2016-03-31 06:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845813002/20001
4 years, 8 months ago (2016-03-31 06:44:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 07:28:43 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3044c21c2c8dadd5531258238b8befe6e1ff21fb Cr-Commit-Position: refs/heads/master@{#384210}
4 years, 8 months ago (2016-03-31 07:30:10 UTC) #9
Evan Stade
4 years, 8 months ago (2016-03-31 16:29:32 UTC) #10
Message was sent while issue was closed.
lgtm

I still suspect there are many places in Chrome where incognito and OffTheRecord
are wrongly conflated.

Powered by Google App Engine
This is Rietveld 408576698