Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: chrome/browser/ui/views/tabs/tab_strip_controller.h

Issue 1845813002: Suspected fix for a tab image caching bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simpler comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_controller.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "chrome/browser/ui/views/tabs/tab_strip_types.h" 9 #include "chrome/browser/ui/views/tabs/tab_strip_types.h"
10 #include "third_party/skia/include/core/SkColor.h" 10 #include "third_party/skia/include/core/SkColor.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 virtual bool IsCompatibleWith(TabStrip* other) const = 0; 93 virtual bool IsCompatibleWith(TabStrip* other) const = 0;
94 94
95 // Creates the new tab. 95 // Creates the new tab.
96 virtual void CreateNewTab() = 0; 96 virtual void CreateNewTab() = 0;
97 97
98 // Creates a new tab, and loads |location| in the tab. If |location| is a 98 // Creates a new tab, and loads |location| in the tab. If |location| is a
99 // valid URL, then simply loads the URL, otherwise this can open a 99 // valid URL, then simply loads the URL, otherwise this can open a
100 // search-result page for |location|. 100 // search-result page for |location|.
101 virtual void CreateNewTabWithLocation(const base::string16& location) = 0; 101 virtual void CreateNewTabWithLocation(const base::string16& location) = 0;
102 102
103 // Returns true if the tab strip is in an incognito window. 103 // Returns true if the tab strip is in an incognito window. This is used to
104 // determining which theme may have applied to it, so this determination
105 // should match the one in ThemeService::GetThemeProviderForProfile().
104 virtual bool IsIncognito() = 0; 106 virtual bool IsIncognito() = 0;
105 107
106 // Invoked if the stacked layout (on or off) might have changed. 108 // Invoked if the stacked layout (on or off) might have changed.
107 virtual void StackedLayoutMaybeChanged() = 0; 109 virtual void StackedLayoutMaybeChanged() = 0;
108 110
109 // Notifies controller that the user started dragging this tabstrip's tabs. 111 // Notifies controller that the user started dragging this tabstrip's tabs.
110 virtual void OnStartedDraggingTabs() = 0; 112 virtual void OnStartedDraggingTabs() = 0;
111 113
112 // Notifies controller that the user stopped dragging this tabstrip's tabs. 114 // Notifies controller that the user stopped dragging this tabstrip's tabs.
113 // This is also called when the tabs that the user is dragging were detached 115 // This is also called when the tabs that the user is dragging were detached
114 // from this tabstrip but the user is still dragging the tabs. 116 // from this tabstrip but the user is still dragging the tabs.
115 virtual void OnStoppedDraggingTabs() = 0; 117 virtual void OnStoppedDraggingTabs() = 0;
116 118
117 // Determines if the file type of the URL is supported. Should invoke 119 // Determines if the file type of the URL is supported. Should invoke
118 // TabStrip::FileSupported to report the result. 120 // TabStrip::FileSupported to report the result.
119 virtual void CheckFileSupported(const GURL& url) = 0; 121 virtual void CheckFileSupported(const GURL& url) = 0;
120 122
121 // Returns COLOR_TOOLBAR_TOP_SEPARATOR[,_INACTIVE] depending on the activation 123 // Returns COLOR_TOOLBAR_TOP_SEPARATOR[,_INACTIVE] depending on the activation
122 // state of the window. 124 // state of the window.
123 virtual SkColor GetToolbarTopSeparatorColor() const = 0; 125 virtual SkColor GetToolbarTopSeparatorColor() const = 0;
124 }; 126 };
125 127
126 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_ 128 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698