Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1845773002: Enable DRP config service by default (Closed)

Created:
4 years, 8 months ago by tbansal1
Modified:
4 years, 8 months ago
Reviewers:
sclittle
CC:
chromium-reviews, asvitkine+watch_chromium.org, Steven Holte
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable DRP config service by default We have been running this experiment at 50% stable, and are now ready to move to 100%. This CL does not remove the code that will now be deprecated because of DRP config being enabled 100% of time. We should remove that code at some point in future. This is reland of https://codereview.chromium.org/1830343002/ which had to be reverted because of failing tests. BUG=597768 TBR=holte@chromium.org Committed: https://crrev.com/57d8bc8d65f8bc73ce8c74e7b092c19002ca5c3a Cr-Commit-Position: refs/heads/master@{#384319}

Patch Set 1 : Commit from https://codereview.chromium.org/1830343002/ #

Patch Set 2 : Do not use client config for Cronet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -192 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 3 chunks +3 lines, -19 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 4 chunks +2 lines, -101 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_ios.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
tbansal1
sclittle: PTAL. Thanks.
4 years, 8 months ago (2016-03-31 00:43:16 UTC) #3
tbansal1
TBR'ing holte@ since this is a reland of the previous CL.
4 years, 8 months ago (2016-03-31 00:44:04 UTC) #5
sclittle
lgtm
4 years, 8 months ago (2016-03-31 00:46:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845773002/20001
4 years, 8 months ago (2016-03-31 00:48:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/188603)
4 years, 8 months ago (2016-03-31 01:04:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845773002/40001
4 years, 8 months ago (2016-03-31 17:26:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-03-31 17:33:22 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:34:18 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57d8bc8d65f8bc73ce8c74e7b092c19002ca5c3a
Cr-Commit-Position: refs/heads/master@{#384319}

Powered by Google App Engine
This is Rietveld 408576698