Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1845773002: Enable DRP config service by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not use client config for Cronet Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 {"enable-data-reduction-proxy-lo-fi-preview", 1465 {"enable-data-reduction-proxy-lo-fi-preview",
1466 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME, 1466 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME,
1467 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll, 1467 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll,
1468 SINGLE_VALUE_TYPE( 1468 SINGLE_VALUE_TYPE(
1469 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)}, 1469 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)},
1470 {"clear-data-reduction-proxy-data-savings", 1470 {"clear-data-reduction-proxy-data-savings",
1471 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME, 1471 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME,
1472 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll, 1472 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll,
1473 SINGLE_VALUE_TYPE( 1473 SINGLE_VALUE_TYPE(
1474 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)}, 1474 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)},
1475 {"enable-data-reduction-proxy-config-client",
1476 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_NAME,
1477 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_DESCRIPTION, kOsAll,
1478 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1479 kEnableDataReductionProxyConfigClient)},
1480 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST, 1475 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST,
1481 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll, 1476 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll,
1482 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1477 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1483 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME, 1478 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME,
1484 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop, 1479 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop,
1485 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1480 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf,
1486 switches::kDisableAddToShelf)}, 1481 switches::kDisableAddToShelf)},
1487 {"bypass-app-banner-engagement-checks", 1482 {"bypass-app-banner-engagement-checks",
1488 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME, 1483 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME,
1489 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll, 1484 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll,
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1903 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) || 1898 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) ||
1904 !strcmp("enable-data-reduction-proxy-lo-fi-preview", 1899 !strcmp("enable-data-reduction-proxy-lo-fi-preview",
1905 entry.internal_name)) && 1900 entry.internal_name)) &&
1906 channel != version_info::Channel::BETA && 1901 channel != version_info::Channel::BETA &&
1907 channel != version_info::Channel::DEV && 1902 channel != version_info::Channel::DEV &&
1908 channel != version_info::Channel::CANARY && 1903 channel != version_info::Channel::CANARY &&
1909 channel != version_info::Channel::UNKNOWN) { 1904 channel != version_info::Channel::UNKNOWN) {
1910 return true; 1905 return true;
1911 } 1906 }
1912 1907
1913 // enable-data-reduction-proxy-config-client is only available for Chromium
1914 // builds and the Canary/Dev channels.
1915 if (!strcmp("enable-data-reduction-proxy-config-client",
1916 entry.internal_name) &&
1917 channel != version_info::Channel::DEV &&
1918 channel != version_info::Channel::CANARY &&
1919 channel != version_info::Channel::UNKNOWN) {
1920 return true;
1921 }
1922
1923 return false; 1908 return false;
1924 } 1909 }
1925 1910
1926 } // namespace 1911 } // namespace
1927 1912
1928 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage, 1913 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage,
1929 base::CommandLine* command_line, 1914 base::CommandLine* command_line,
1930 flags_ui::SentinelsMode sentinels) { 1915 flags_ui::SentinelsMode sentinels) {
1931 if (command_line->HasSwitch(switches::kNoExperiments)) 1916 if (command_line->HasSwitch(switches::kNoExperiments))
1932 return; 1917 return;
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2034 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2019 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2035 2020
2036 const FeatureEntry* GetFeatureEntries(size_t* count) { 2021 const FeatureEntry* GetFeatureEntries(size_t* count) {
2037 *count = arraysize(kFeatureEntries); 2022 *count = arraysize(kFeatureEntries);
2038 return kFeatureEntries; 2023 return kFeatureEntries;
2039 } 2024 }
2040 2025
2041 } // namespace testing 2026 } // namespace testing
2042 2027
2043 } // namespace about_flags 2028 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698