Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1845643002: Initialize next_update_time_ to allow immediate updating (Closed)

Created:
4 years, 8 months ago by vakh (use Gerrit instead)
Modified:
4 years, 8 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize next_update_time_ to allow immediate updating BUG=598412 Committed: https://crrev.com/531801a428d092a4bd50b0e75d5ba03cd1c21612 Cr-Commit-Position: refs/heads/master@{#384112}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Initialize next_update_time_ with time=0 instead of now-1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -30 lines) Patch
M components/safe_browsing_db/v4_update_protocol_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 3 chunks +4 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
vakh (use Gerrit instead)
4 years, 8 months ago (2016-03-30 18:24:11 UTC) #2
Nathan Parker
lgtm Nice find! https://codereview.chromium.org/1845643002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.cc File components/safe_browsing_db/v4_update_protocol_manager.cc (right): https://codereview.chromium.org/1845643002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.cc#newcode106 components/safe_browsing_db/v4_update_protocol_manager.cc:106: next_update_time_(Time::Now() - base::TimeDelta::FromMilliseconds(1)), Why not zero? ...
4 years, 8 months ago (2016-03-30 20:12:16 UTC) #3
vakh (use Gerrit instead)
Initialize next_update_time_ with time=0 instead of now-1
4 years, 8 months ago (2016-03-30 21:00:46 UTC) #4
vakh (use Gerrit instead)
PTAL. Thanks. https://codereview.chromium.org/1845643002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.cc File components/safe_browsing_db/v4_update_protocol_manager.cc (right): https://codereview.chromium.org/1845643002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.cc#newcode106 components/safe_browsing_db/v4_update_protocol_manager.cc:106: next_update_time_(Time::Now() - base::TimeDelta::FromMilliseconds(1)), On 2016/03/30 20:12:16, Nathan ...
4 years, 8 months ago (2016-03-30 21:04:14 UTC) #5
Nathan Parker
LGTM still Meta: My "lgtm + comments" generally mean "address the comments and then feel ...
4 years, 8 months ago (2016-03-30 22:03:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845643002/20001
4 years, 8 months ago (2016-03-30 22:04:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 22:10:20 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 22:12:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/531801a428d092a4bd50b0e75d5ba03cd1c21612
Cr-Commit-Position: refs/heads/master@{#384112}

Powered by Google App Engine
This is Rietveld 408576698