Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1845533002: Remove HTMLPlugin WTF logging. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTMLPlugin WTF logging. Replace two Plugins logging with VLOG(1). This has a slight change in that it uses operator<< on Node.h as opposed to logging the address of the HTML Plugin Element; I do think this is slightly more useful than the previous log info. BUG=596760 Committed: https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f Cr-Commit-Position: refs/heads/master@{#383902}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove utf8 conversions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dtapuska
4 years, 8 months ago (2016-03-30 02:11:21 UTC) #3
tkent
https://codereview.chromium.org/1845533002/diff/1/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right): https://codereview.chromium.org/1845533002/diff/1/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp#newcode510 third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:510: VLOG(1) << this << " Plugin URL: " << ...
4 years, 8 months ago (2016-03-30 02:16:30 UTC) #4
dtapuska
https://codereview.chromium.org/1845533002/diff/1/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right): https://codereview.chromium.org/1845533002/diff/1/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp#newcode510 third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:510: VLOG(1) << this << " Plugin URL: " << ...
4 years, 8 months ago (2016-03-30 02:30:12 UTC) #5
tkent
lgtm
4 years, 8 months ago (2016-03-30 02:36:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845533002/20001
4 years, 8 months ago (2016-03-30 02:36:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 03:49:25 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 03:50:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f
Cr-Commit-Position: refs/heads/master@{#383902}

Powered by Google App Engine
This is Rietveld 408576698