Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1845533002: Remove HTMLPlugin WTF logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/Logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 500
501 LocalFrame* frame = document().frame(); 501 LocalFrame* frame = document().frame();
502 if (!frame->loader().allowPlugins(AboutToInstantiatePlugin)) 502 if (!frame->loader().allowPlugins(AboutToInstantiatePlugin))
503 return false; 503 return false;
504 504
505 LayoutEmbeddedItem layoutItem = layoutEmbeddedItem(); 505 LayoutEmbeddedItem layoutItem = layoutEmbeddedItem();
506 // FIXME: This code should not depend on layoutObject! 506 // FIXME: This code should not depend on layoutObject!
507 if ((layoutItem.isNull() && requireLayoutObject) || useFallback) 507 if ((layoutItem.isNull() && requireLayoutObject) || useFallback)
508 return false; 508 return false;
509 509
510 WTF_LOG(Plugins, "%p Plugin URL: %s", this, m_url.utf8().data()); 510 VLOG(1) << this << " Plugin URL: " << m_url.utf8().data();
tkent 2016/03/30 02:16:29 m_url.utf8().data() > m_url
dtapuska 2016/03/30 02:30:12 Done.
511 WTF_LOG(Plugins, " Loaded URL: %s", url.getString().utf8().data()); 511 VLOG(1) << "Loaded URL: " << url.getString().utf8().data();
tkent 2016/03/30 02:16:29 url.getString().utf8().data() -> url.getString()
dtapuska 2016/03/30 02:30:11 Done.
512 m_loadedUrl = url; 512 m_loadedUrl = url;
513 513
514 if (m_persistedPluginWidget) { 514 if (m_persistedPluginWidget) {
515 setWidget(m_persistedPluginWidget.release()); 515 setWidget(m_persistedPluginWidget.release());
516 } else { 516 } else {
517 bool loadManually = document().isPluginDocument() && !document().contain sPlugins(); 517 bool loadManually = document().isPluginDocument() && !document().contain sPlugins();
518 FrameLoaderClient::DetachedPluginPolicy policy = requireLayoutObject ? F rameLoaderClient::FailOnDetachedPlugin : FrameLoaderClient::AllowDetachedPlugin; 518 FrameLoaderClient::DetachedPluginPolicy policy = requireLayoutObject ? F rameLoaderClient::FailOnDetachedPlugin : FrameLoaderClient::AllowDetachedPlugin;
519 RefPtrWillBeRawPtr<Widget> widget = frame->loader().client()->createPlug in(this, url, paramNames, paramValues, mimeType, loadManually, policy); 519 RefPtrWillBeRawPtr<Widget> widget = frame->loader().client()->createPlug in(this, url, paramNames, paramValues, mimeType, loadManually, policy);
520 if (!widget) { 520 if (!widget) {
521 if (!layoutItem.isNull() && !layoutItem.showsUnavailablePluginIndica tor()) 521 if (!layoutItem.isNull() && !layoutItem.showsUnavailablePluginIndica tor())
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 return openShadowRoot(); 631 return openShadowRoot();
632 } 632 }
633 633
634 void HTMLPlugInElement::lazyReattachIfNeeded() 634 void HTMLPlugInElement::lazyReattachIfNeeded()
635 { 635 {
636 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) 636 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType())
637 lazyReattachIfAttached(); 637 lazyReattachIfAttached();
638 } 638 }
639 639
640 } // namespace blink 640 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/Logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698