Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugcrash
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index e0ce947149a6a087e622cbf3993904b0e802fea6..0b875f444f40409485912359a4631757e0d20ee3 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -8,6 +8,8 @@ import android.content.Context;
import android.graphics.Rect;
import android.os.Build;
import android.os.Bundle;
+import android.text.SpannableString;
+import android.text.style.URLSpan;
import android.view.MotionEvent;
import android.view.View;
import android.view.ViewParent;
@@ -442,10 +444,21 @@ public class BrowserAccessibilityManager {
}
@CalledByNative
- private void setAccessibilityNodeInfoStringAttributes(AccessibilityNodeInfo node,
- String className, String contentDescription) {
+ private void setAccessibilityNodeInfoClassName(AccessibilityNodeInfo node,
+ String className) {
node.setClassName(className);
- node.setContentDescription(contentDescription);
+ }
+
+ @CalledByNative
+ private void setAccessibilityNodeInfoContentDescription(
+ AccessibilityNodeInfo node, String contentDescription, boolean annotateAsLink) {
+ CharSequence charSeq = contentDescription;
Kristian Monsen 2014/03/05 07:43:55 Maybe a more descriptive name? (desciption?)
+ if (annotateAsLink) {
+ SpannableString spannable = new SpannableString(charSeq);
+ spannable.setSpan(new URLSpan(""), 0, charSeq.length(), 0);
+ charSeq = spannable;
+ }
+ node.setContentDescription(charSeq);
Kristian Monsen 2014/03/05 07:43:55 I would probably just do if else, then you don't h
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698