Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugcrash
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc
index b86374a02ec354ff79f3e20180ccf48b64ba865e..83985c6fe91bc589bd382fe584ad444e98ca4fc1 100644
--- a/content/browser/accessibility/browser_accessibility_android.cc
+++ b/content/browser/accessibility/browser_accessibility_android.cc
@@ -191,6 +191,10 @@ bool BrowserAccessibilityAndroid::IsVisibleToUser() const {
return !HasState(ui::AX_STATE_INVISIBLE);
}
+bool BrowserAccessibilityAndroid::IsLink() const {
dmazzoni 2014/03/03 22:41:28 Nit: same sorted order
+ return role() == ui::AX_ROLE_LINK || role() == ui::AX_ROLE_IMAGE_MAP_LINK;
+}
+
bool BrowserAccessibilityAndroid::CanOpenPopup() const {
return HasState(ui::AX_STATE_HASPOPUP);
}
@@ -280,12 +284,6 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {
}
switch(role()) {
- case ui::AX_ROLE_IMAGE_MAP_LINK:
- case ui::AX_ROLE_LINK:
- if (!text.empty())
- text += base::ASCIIToUTF16(" ");
- text += base::ASCIIToUTF16("Link");
- break;
case ui::AX_ROLE_HEADING:
// Only append "heading" if this node already has text.
if (!text.empty())

Powered by Google App Engine
This is Rietveld 408576698