Added Vulkan Validation to Instance/Device objects.

Added Vulkan Validation to Instance/Device objects.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/5bd6d4f9ce27cc7f07dccfe8e4860e6a99ad2e18
Cr-Commit-Position: refs/heads/master@{#384284}

[David Yen, 2016-03-30 00:38:28]

Description was changed from

==========
Added Vulkan Validation to Instance/Device objects.

R=piman@chromium.org
BUG=582558
==========

to

==========
Added Vulkan Validation to Instance/Device objects.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[David Yen, 2016-03-30 00:41:07]

Hmm... there were a bunch of header changes so I have to make sure
logging/macros are both included separately. I might have to put these changes
back in the dependent patches first or they won't compile.

This is the downside of having no bot :(

[David Yen, 2016-03-30 18:11:48]

Ok, I made the logging.h/macros.h changes in the dependent CLs so this CL only
contains validation code now.

[David Yen, 2016-03-30 18:49:09]

On 2016/03/30 18:11:48, David Yen wrote:
> Ok, I made the logging.h/macros.h changes in the dependent CLs so this CL only
> contains validation code now.

I upgraded my SDK to 1.0.5 and it looks like they added
VK_LAYER_LUNARG_standard_validation so I am using that instead now. Also this
actually caught an error, I was not including vulkan_platform in
vulkan_implementation.cc. The downside of separating out the platform specific
code is it doesn't give compile errors if you forgot to include it.

[piman, 2016-03-30 21:15:25]

lgtm

[David Yen, 2016-03-30 23:22:30]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-03-30 23:22:30]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1845493002/#ps100001
(title: "Block off vulkan_cc with enable_cc")

[commit-bot: I haz the power, 2016-03-30 23:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:22:57]

This CL has an open dependency (Issue 1829163003 Patch 160001). Please resolve
the dependency and try again.

[David Yen, 2016-03-31 00:49:39]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-03-31 00:49:39]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1845493002/#ps120001
(title: "Revert Patch #6, wrong CL again :(")

[commit-bot: I haz the power, 2016-03-31 00:50:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845493002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845493002/120001

[commit-bot: I haz the power, 2016-03-31 07:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 07:07:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Yen, 2016-03-31 14:45:29]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2016-03-31 14:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845493002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845493002/120001

[commit-bot: I haz the power, 2016-03-31 15:25:54]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-31 15:28:28]

Description was changed from

==========
Added Vulkan Validation to Instance/Device objects.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Added Vulkan Validation to Instance/Device objects.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/5bd6d4f9ce27cc7f07dccfe8e4860e6a99ad2e18
Cr-Commit-Position: refs/heads/master@{#384284}
==========

[commit-bot: I haz the power, 2016-03-31 15:28:30]

Patchset 7 (id:??) landed as
https://crrev.com/5bd6d4f9ce27cc7f07dccfe8e4860e6a99ad2e18
Cr-Commit-Position: refs/heads/master@{#384284}