Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1829163003: Added initial implementation of the Vulkan Context Provider. (Closed)

Created:
4 years, 9 months ago by David Yen
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vk_surface_patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added initial implementation of the Vulkan Context Provider. The Vulkan Device/Queue has been included into a custom class which will be provided by the vulkan context provider. The context provider will be how we manage sharing of vulkan objects. R=piman@chromium.org BUG=582558 582564 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8a145fb7cc4b9882b69f0bd7efd6b8b2601d1205 Cr-Commit-Position: refs/heads/master@{#384161}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase + fixed includes #

Patch Set 4 : Fix patch dependency? #

Patch Set 5 : rebase again #

Patch Set 6 : Added logging/macros headers. #

Patch Set 7 : format #

Patch Set 8 : format #

Patch Set 9 : +ui.gni in CC #

Patch Set 10 : Block off vulkan_cc with enable_vulkan (not relevant in future patch) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -200 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +23 lines, -0 lines 0 comments Download
M cc/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A cc/output/vulkan_context_provider.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A cc/output/vulkan_in_process_context_provider.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A cc/output/vulkan_in_process_context_provider.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M gpu/vulkan/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/vulkan/tests/vulkan_test.cc View 1 2 6 chunks +14 lines, -4 lines 0 comments Download
M gpu/vulkan/vulkan_command_buffer.h View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M gpu/vulkan/vulkan_command_buffer.cc View 1 2 3 4 5 6 7 chunks +27 lines, -11 lines 0 comments Download
M gpu/vulkan/vulkan_command_pool.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/vulkan/vulkan_command_pool.cc View 1 2 3 4 5 5 chunks +11 lines, -8 lines 0 comments Download
A gpu/vulkan/vulkan_device_queue.h View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
A gpu/vulkan/vulkan_device_queue.cc View 1 chunk +144 lines, -0 lines 0 comments Download
M gpu/vulkan/vulkan_image_view.h View 3 chunks +4 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_image_view.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M gpu/vulkan/vulkan_implementation.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/vulkan/vulkan_implementation.cc View 1 2 3 4 5 4 chunks +2 lines, -134 lines 0 comments Download
M gpu/vulkan/vulkan_render_pass.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_render_pass.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M gpu/vulkan/vulkan_surface.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_surface.cc View 1 2 3 4 6 chunks +27 lines, -9 lines 0 comments Download
M gpu/vulkan/vulkan_swap_chain.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_swap_chain.cc View 1 2 3 4 12 chunks +16 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
David Yen
This should work as an initial base for what VulkanRenderer will depend on. I've moved ...
4 years, 9 months ago (2016-03-25 01:05:05 UTC) #3
piman
LGTM, this is better.
4 years, 9 months ago (2016-03-25 02:05:18 UTC) #4
David Yen
On 2016/03/25 02:05:18, piman wrote: > LGTM, this is better. Hmm, one strange thing that ...
4 years, 9 months ago (2016-03-26 00:49:38 UTC) #5
piman
On 2016/03/26 00:49:38, David Yen wrote: > On 2016/03/25 02:05:18, piman wrote: > > LGTM, ...
4 years, 9 months ago (2016-03-26 01:25:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829163003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829163003/140001
4 years, 8 months ago (2016-03-30 23:00:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/84244) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-03-30 23:05:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829163003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829163003/160001
4 years, 8 months ago (2016-03-30 23:09:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/84245) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-03-30 23:14:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829163003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829163003/180001
4 years, 8 months ago (2016-03-30 23:24:06 UTC) #19
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 8 months ago (2016-03-31 00:38:00 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 00:39:18 UTC) #22
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/8a145fb7cc4b9882b69f0bd7efd6b8b2601d1205
Cr-Commit-Position: refs/heads/master@{#384161}

Powered by Google App Engine
This is Rietveld 408576698