Makes MaterialDesignController initialization explicit

chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc

Index: chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
diff --git a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc b/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
index 1254e592c25df24251529da8da6a34c5ca75ae2d..953c41e26677531086906f68d701d7472fab2b13 100644
--- a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
+++ b/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
@@ -78,10 +78,10 @@ void ChromeBrowserMainExtraPartsViewsLinux::PreEarlyInitialization() {
 
 void ChromeBrowserMainExtraPartsViewsLinux::ToolkitInitialized() {
   ChromeBrowserMainExtraPartsViews::ToolkitInitialized();

[Evan Stade, 2016/04/01 17:03:20]

do you still need this?

[varkha, 2016/04/01 18:36:22]

No, it is a NOP.

-  views::LinuxUI::instance()->Initialize();
 }
 
 void ChromeBrowserMainExtraPartsViewsLinux::PreCreateThreads() {
+  views::LinuxUI::instance()->Initialize();

[Evan Stade, 2016/04/01 17:03:20]

This seems wrong. According to documentation, this should be part of
ToolkitInitialized. Also note this comment:

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/br...

[varkha, 2016/04/01 18:36:22]

Yes, this is probably a non-starter although I could not find what it really
breaks (if anything) on Linux.

Do you think it would be promising to see if we can isolate generation of
colors_[ThemeProperties::COLOR_BACKGROUND_TAB_TEXT] in gtk2_ui.cc? That seems to
be the only thing that needs to know MD mode so maybe we could leave the code
as-is but add a call through that updates the colors to MD.

[varkha, 2016/04/01 19:09:03]

PTAL at the last patch set if you think that this could work.

   ChromeBrowserMainExtraPartsViews::PreCreateThreads();
   views::LinuxUI::instance()->UpdateDeviceScaleFactor(
       gfx::Screen::GetScreen()->GetPrimaryDisplay().device_scale_factor());