Makes MaterialDesignController initialization explicit

chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "chrome/browser/chrome_browser_main.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 59 matching lines @@
     ~ChromeBrowserMainExtraPartsViewsLinux() {}
 
 void ChromeBrowserMainExtraPartsViewsLinux::PreEarlyInitialization() {
   // TODO(erg): Refactor this into a dlopen call when we add a GTK3 port.
   views::LinuxUI* gtk2_ui = BuildGtk2UI();
   gtk2_ui->SetNativeThemeOverride(base::Bind(&GetNativeThemeForWindow));
   views::LinuxUI::SetInstance(gtk2_ui);
 }
 
 void ChromeBrowserMainExtraPartsViewsLinux::ToolkitInitialized() {
   ChromeBrowserMainExtraPartsViews::ToolkitInitialized();

[Evan Stade, 2016/04/01 17:03:20]

do you still need this?

[varkha, 2016/04/01 18:36:22]

No, it is a NOP.

-  views::LinuxUI::instance()->Initialize();
 }
 
 void ChromeBrowserMainExtraPartsViewsLinux::PreCreateThreads() {
+  views::LinuxUI::instance()->Initialize();

[Evan Stade, 2016/04/01 17:03:20]

This seems wrong. According to documentation, this should be part of
ToolkitInitialized. Also note this comment:

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/br...

[varkha, 2016/04/01 18:36:22]

Yes, this is probably a non-starter although I could not find what it really
breaks (if anything) on Linux.

Do you think it would be promising to see if we can isolate generation of
colors_[ThemeProperties::COLOR_BACKGROUND_TAB_TEXT] in gtk2_ui.cc? That seems to
be the only thing that needs to know MD mode so maybe we could leave the code
as-is but add a call through that updates the colors to MD.

[varkha, 2016/04/01 19:09:03]

PTAL at the last patch set if you think that this could work.

   ChromeBrowserMainExtraPartsViews::PreCreateThreads();
   views::LinuxUI::instance()->UpdateDeviceScaleFactor(
       gfx::Screen::GetScreen()->GetPrimaryDisplay().device_scale_factor());
 }
 
 void ChromeBrowserMainExtraPartsViewsLinux::PreProfileInit() {
   // On the Linux desktop, we want to prevent the user from logging in as root,
   // so that we don't destroy the profile. Now that we have some minimal ui
   // initialized, check to see if we're running as root and bail if we are.
   if (getuid() != 0)
@@ skipping 10 matching lines @@
       IDS_REFUSE_TO_RUN_AS_ROOT_2, l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
 
   chrome::ShowWarningMessageBox(NULL, title, message);
 
   // Avoids gpu_process_transport_factory.cc(153)] Check failed:
   // per_compositor_data_.empty() when quit is chosen.
   base::RunLoop().RunUntilIdle();
 
   exit(EXIT_FAILURE);
 }