Remode dead code from SkReadBuffer

Remode dead code from SkReadBuffer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845283002

Committed: https://skia.googlesource.com/skia/+/d19d83ce5e3e388fadea0e02d99a645364d41640

[msarett, 2016-03-31 15:03:34]

Description was changed from

==========
Remode dead code from SkReadBuffer

BUG=skia:
==========

to

==========
Remode dead code from SkReadBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-31 15:05:34]

msarett@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[msarett, 2016-03-31 15:05:35]

https://codereview.chromium.org/1845283002/diff/1/src/core/SkReadBuffer.cpp
File src/core/SkReadBuffer.cpp (left):

https://codereview.chromium.org/1845283002/diff/1/src/core/SkReadBuffer.cpp#o...
src/core/SkReadBuffer.cpp:359: if ((unsigned)index >= (unsigned)fFactoryCount) {
AFAICT, fFactoryCount is always zero when fFactoryTDArray is non-NULL.  So this
case never works...

https://codereview.chromium.org/1845283002/diff/1/src/core/SkReadBuffer.h
File src/core/SkReadBuffer.h (left):

https://codereview.chromium.org/1845283002/diff/1/src/core/SkReadBuffer.h#old...
src/core/SkReadBuffer.h:210: void
setFactoryArray(SkTDArray<SkFlattenable::Factory>* array) {
Nobody calls this.

[mtklein, 2016-03-31 15:13:16]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-03-31 15:13:17]

lgtm

[commit-bot: I haz the power, 2016-03-31 15:13:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845283002/1

[commit-bot: I haz the power, 2016-03-31 15:25:21]

Description was changed from

==========
Remode dead code from SkReadBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remode dead code from SkReadBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d19d83ce5e3e388fadea0e02d99a645364d41640
==========

[commit-bot: I haz the power, 2016-03-31 15:25:22]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d19d83ce5e3e388fadea0e02d99a645364d41640