Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845273004: Allows adding trusted certs on iOS. (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : De-dup ScopedMemBuffer #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -75 lines) Patch
M runtime/bin/secure_socket_ios.cc View 1 2 3 5 chunks +44 lines, -14 lines 0 comments Download
M runtime/bin/secure_socket_macos.h View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket_macos.cc View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
M sdk/lib/io/security_context.dart View 1 2 3 4 8 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 8 months ago (2016-03-31 21:50:42 UTC) #2
Ivan Posva
LGTM -Ivan https://codereview.chromium.org/1845273004/diff/40001/sdk/lib/io/security_context.dart File sdk/lib/io/security_context.dart (right): https://codereview.chromium.org/1845273004/diff/40001/sdk/lib/io/security_context.dart#newcode18 sdk/lib/io/security_context.dart:18: * iOS note: some methods to add, ...
4 years, 8 months ago (2016-03-31 22:47:27 UTC) #3
zra
https://codereview.chromium.org/1845273004/diff/40001/sdk/lib/io/security_context.dart File sdk/lib/io/security_context.dart (right): https://codereview.chromium.org/1845273004/diff/40001/sdk/lib/io/security_context.dart#newcode18 sdk/lib/io/security_context.dart:18: * iOS note: some methods to add, remove, and ...
4 years, 8 months ago (2016-03-31 22:51:01 UTC) #4
zra
4 years, 8 months ago (2016-03-31 22:51:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
b0475caa7f6225203459c991b10f6c45133a7684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698