Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: sdk/lib/io/security_context.dart

Issue 1845273004: Allows adding trusted certs on iOS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/secure_socket_macos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/security_context.dart
diff --git a/sdk/lib/io/security_context.dart b/sdk/lib/io/security_context.dart
index 41464206d215b7e523fbec08f73c5e280237eb7f..190957185789d3b0455d96780a24bd5d0d8ce748 100644
--- a/sdk/lib/io/security_context.dart
+++ b/sdk/lib/io/security_context.dart
@@ -15,8 +15,8 @@ part of dart.io;
* Certificates and keys can be added to a SecurityContext from either PEM
* or PKCS12 containers.
*
- * iOS note: methods to add, remove, and inspect certificates are not yet
- * implemented. That is, only the platform's built-in trusted certificates can
+ * iOS note: Some methods to add, remove, and inspect certificates are not yet
+ * implemented. However, the platform's built-in trusted certificates can
* be used, by way of [SecurityContext.defaultContext].
*/
abstract class SecurityContext {
@@ -47,6 +47,8 @@ abstract class SecurityContext {
*
* NB: This function calls [ReadFileAsBytesSync], and will block on file IO.
* Prefer using [usePrivateKeyBytes].
+ *
+ * iOS note: Not yet implemented.
*/
void usePrivateKey(String file, {String password});
@@ -55,6 +57,8 @@ abstract class SecurityContext {
*
* Like [usePrivateKey], but takes the contents of the file as a list
* of bytes.
+ *
+ * iOS note: Not yet implemented.
*/
void usePrivateKeyBytes(List<int> keyBytes, {String password});
@@ -78,6 +82,13 @@ abstract class SecurityContext {
* client connections, when connecting to a secure server.
*
* Like [setTrustedCertificates] but takes the contents of the file.
+ *
+ * iOS note: On iOS, this call takes only the bytes for a single DER
+ * encoded X509 certificate. It may be called multiple times to add
+ * multiple trusted certificates to the context. A DER encoded certificate
+ * can be obtained from a PEM encoded certificate by using the openssl tool:
+ *
+ * $ openssl x509 -outform der -in cert.pem -out cert.der
*/
void setTrustedCertificatesBytes(List<int> certBytes, {String password});
@@ -95,6 +106,8 @@ abstract class SecurityContext {
*
* NB: This function calls [ReadFileAsBytesSync], and will block on file IO.
* Prefer using [useCertificateChainBytes].
+ *
+ * iOS note: Not yet implemented.
*/
void useCertificateChain(String file, {String password});
@@ -103,6 +116,8 @@ abstract class SecurityContext {
* when making secure connections, including the server certificate.
*
* Like [useCertificateChain] but takes the contents of the file.
+ *
+ * iOS note: Not yet implemented.
*/
void useCertificateChainBytes(List<int> chainBytes, {String password});
@@ -119,6 +134,8 @@ abstract class SecurityContext {
*
* NB: This function calls [ReadFileAsBytesSync], and will block on file IO.
* Prefer using [setClientAuthoritiesBytes].
+ *
+ * iOS note: Not yet implemented.
*/
void setClientAuthorities(String file, {String password});
@@ -128,6 +145,8 @@ abstract class SecurityContext {
* client.
*
* Like [setClientAuthority] but takes the contents of the file.
+ *
+ * iOS note: Not yet implemented.
*/
void setClientAuthoritiesBytes(List<int> authCertBytes, {String password});
« no previous file with comments | « runtime/bin/secure_socket_macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698