Chromium Code Reviews

Issue 1845263002: [chrome.displaySource] Fix API conversion to moveable types. (Closed)

Created:
4 years, 8 months ago by e_hakkinen
Modified:
4 years, 8 months ago
Reviewers:
Mikhail
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Fix API conversion to moveable types. Not all display source files were converted to use moveable types by https://codereview.chromium.org/1841483002. That rendered display source uncompilable. This CL finishes the conversion. BUG=242107, 595949 Committed: https://crrev.com/f501c58425cbab94a2f1004f20102353665da37c Cr-Commit-Position: refs/heads/master@{#384517}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+18 lines, -15 lines)
M extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc View 5 chunks +18 lines, -15 lines 0 comments

Messages

Total messages: 11 (6 generated)
e_hakkinen
PTAL.
4 years, 8 months ago (2016-03-31 13:45:49 UTC) #2
Mikhail
lgtm
4 years, 8 months ago (2016-04-01 07:18:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845263002/1
4 years, 8 months ago (2016-04-01 07:18:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 08:13:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 08:14:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f501c58425cbab94a2f1004f20102353665da37c
Cr-Commit-Position: refs/heads/master@{#384517}

Powered by Google App Engine