Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1841483002: [Extensions] Convert APIs to use movable types [11] (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [11] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - bluetooth.idl - bluetooth_private.idl - bluetooth_socket.idl - cast_channel.idl - declarative_web_request.json - diagnostics.idl - display_source.idl - dns.idl - document_scan.idl - events.json - extension_options_internal.idl - extension_types.json - extension_view_internal.json - extensions_manifest_types.json - guest_view_internal.json - hid.idl - idle.json Also add templates for movable types with errors. Note: The declarative content API uses events::Rules as linked ptrs to do cheap refcounting (which it shouldn't do). This will be addressed in a separate CL. BUG=595949 Committed: https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899 Cr-Commit-Position: refs/heads/master@{#383804}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -85 lines) Patch
M extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc View 3 chunks +15 lines, -20 lines 0 comments Download
M extensions/browser/api/declarative/declarative_api.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M extensions/browser/api/display_source/display_source_apitest.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M extensions/browser/api/display_source/display_source_connection_delegate.h View 3 chunks +5 lines, -6 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M extensions/common/api/bluetooth.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/bluetooth_private.idl View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/bluetooth_socket.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/cast_channel.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/declarative_web_request.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/diagnostics.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/display_source.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/api/dns.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/document_scan.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/events.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/extension_options_internal.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/extension_types.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/extension_view_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/extensions_manifest_types.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/guest_view_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/hid.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/idle.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M tools/json_schema_compiler/util.h View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
4 years, 8 months ago (2016-03-29 16:53:40 UTC) #6
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-03-29 17:57:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841483002/60001
4 years, 8 months ago (2016-03-29 20:21:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 8 months ago (2016-03-29 20:28:06 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:30:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899
Cr-Commit-Position: refs/heads/master@{#383804}

Powered by Google App Engine
This is Rietveld 408576698