chrome/browser/android/banners/app_banner_data_fetcher_android.h - Issue 1845233002: Store standalone web app data in WebappDataStorage as well as the homescreen intent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.h

Issue 1845233002: Store standalone web app data in WebappDataStorage as well as the homescreen intent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notification-deep-linking

Patch Set: Final nit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.h

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.h b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

index 058415c1eb3719f0fe45568f9b6547b1507caef3..bb83d4503877c6b8d8a10559d5ac0600bff0f60f 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.h

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_DATA_FETCHER_ANDROID_H_

#include "base/android/jni_android.h"

+#include "base/callback_forward.h"

#include "base/macros.h"

#include "chrome/browser/banners/app_banner_data_fetcher.h"

@@ -30,8 +31,10 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

const base::android::JavaRef<jobject>& app_data,

const GURL& image_url);

- // Fetches the splash screen image and stores it in the WebappDataStorage.

- void FetchWebappSplashScreenImage(const std::string& webapp_id);

+ // Returns a callback which fetches the splash screen image and stores it in

+ // WebappDataStorage.

+ base::Closure FetchWebappSplashScreenImageCallback(

+ const std::string& webapp_id);

protected:

~AppBannerDataFetcherAndroid() override;