Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3079)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 1845233002: Store standalone web app data in WebappDataStorage as well as the homescreen intent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notification-deep-linking
Patch Set: Final nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index 276919c3ef540d950b2aa9066ec66b80cd43895a..0ae0671aea23a87c02041846c49356830df5be0a 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -6,6 +6,8 @@
#include <utility>
+#include "base/bind.h"
+#include "base/callback.h"
#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
#include "chrome/browser/android/shortcut_helper.h"
#include "chrome/browser/banners/app_banner_metrics.h"
@@ -57,7 +59,7 @@ std::string AppBannerDataFetcherAndroid::GetAppIdentifier() {
? AppBannerDataFetcher::GetAppIdentifier() : native_app_package_;
}
-void AppBannerDataFetcherAndroid::FetchWebappSplashScreenImage(
+base::Closure AppBannerDataFetcherAndroid::FetchWebappSplashScreenImageCallback(
const std::string& webapp_id) {
content::WebContents* web_contents = GetWebContents();
DCHECK(web_contents);
@@ -66,13 +68,9 @@ void AppBannerDataFetcherAndroid::FetchWebappSplashScreenImage(
web_app_data().icons, ideal_splash_image_size_in_dp_,
minimum_splash_image_size_in_dp_);
- ShortcutHelper::FetchSplashScreenImage(
- web_contents,
- image_url,
- ideal_splash_image_size_in_dp_,
- minimum_splash_image_size_in_dp_,
- webapp_id,
- web_app_data().start_url.spec());
+ return base::Bind(&ShortcutHelper::FetchSplashScreenImage,
+ web_contents, image_url, ideal_splash_image_size_in_dp_,
+ minimum_splash_image_size_in_dp_, webapp_id);
}
void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,

Powered by Google App Engine
This is Rietveld 408576698