Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1844983003: Fix Vulkan tests after GrContextFactory move to sk_gpu_test (Closed)

Created:
4 years, 8 months ago by Kimmo Kinnunen
Modified:
4 years, 8 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Vulkan tests after GrContextFactory move to sk_gpu_test Fix Vulkan tests after GrContextFactory move to sk_gpu_test BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844983003 Committed: https://skia.googlesource.com/skia/+/2ae4b2e95ddd36ede0d3cbc4d274b6d6618a049d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tests/VkClearTests.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/VkUploadPixelsTests.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/VkWrapTests.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
dm does not run for me, though.
4 years, 8 months ago (2016-03-31 11:37:46 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-03-31 14:49:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844983003/1
4 years, 8 months ago (2016-03-31 14:49:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 15:08:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ae4b2e95ddd36ede0d3cbc4d274b6d6618a049d

Powered by Google App Engine
This is Rietveld 408576698