Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1842313003: Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget (Closed)

Created:
4 years, 8 months ago by Kimmo Kinnunen
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget. The function leaks the texture id if kAdopt_LifeCycle is passed. There is no public API to access the parameter. BUG=594928 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842313003 Committed: https://skia.googlesource.com/skia/+/49c4c22b3744d18e1cb38ecabcb8839d2e26afe0

Patch Set 1 #

Patch Set 2 : vulkan #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
M src/gpu/GrGpu.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +8 lines, -18 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
I have another way of fixing, but it is either: a) weird: using GrGpuResource::LifeCycle to ...
4 years, 8 months ago (2016-03-31 11:42:36 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-03-31 14:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842313003/40001
4 years, 8 months ago (2016-04-01 06:36:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:50:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/49c4c22b3744d18e1cb38ecabcb8839d2e26afe0

Powered by Google App Engine
This is Rietveld 408576698