Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1844563004: Make ios_web_shell_test build for xcode-ninja. (Closed)

Created:
4 years, 8 months ago by baxley
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ios_web_shell_test build for xcode-ninja. for xcode-ninja, GENERATOR is set to xcode, and GENERATOR_FLAVOR is set to ninja. BUG= Committed: https://crrev.com/e6e530bd918f0fd277fef0e4dfb4466f99a2b251 Cr-Commit-Position: refs/heads/master@{#383866}

Patch Set 1 #

Patch Set 2 : look for ninja #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/web/ios_web_shell_tests.gyp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
baxley
Had to make this change to make it work within Xcode (for ninja builds).
4 years, 8 months ago (2016-03-29 22:39:18 UTC) #2
justincohen
lgtm
4 years, 8 months ago (2016-03-29 22:40:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844563004/20001
4 years, 8 months ago (2016-03-29 22:42:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/161753)
4 years, 8 months ago (2016-03-29 22:53:28 UTC) #7
baxley
+eugenebut for OWNERS
4 years, 8 months ago (2016-03-29 22:57:53 UTC) #9
Eugene But (OOO till 7-30)
lgtm
4 years, 8 months ago (2016-03-29 23:25:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844563004/20001
4 years, 8 months ago (2016-03-29 23:33:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 23:39:29 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:41:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6e530bd918f0fd277fef0e4dfb4466f99a2b251
Cr-Commit-Position: refs/heads/master@{#383866}

Powered by Google App Engine
This is Rietveld 408576698