Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/ios_web_shell_tests.gyp

Issue 1844563004: Make ios_web_shell_test build for xcode-ninja. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: look for ninja Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/ios_web_shell_tests.gyp
diff --git a/ios/web/ios_web_shell_tests.gyp b/ios/web/ios_web_shell_tests.gyp
index 87cd0d82726602d52dc74ce44b07b49f9e51c350..79c93e8bbefc0705df753455a88025b185efeb56 100644
--- a/ios/web/ios_web_shell_tests.gyp
+++ b/ios/web/ios_web_shell_tests.gyp
@@ -8,8 +8,8 @@
},
'conditions': [
# The iOS frameworks being built for ios_web_shell_test require certs which
- # bot do not currently have installed. Ninja allows this, Xcode does not.
- ['"<(GENERATOR)"=="ninja"', {
+ # bots do not currently have installed. Ninja allows this, Xcode does not.
+ ['"<(GENERATOR)"=="ninja" or "<(GENERATOR_FLAVOR)"=="ninja"', {
'targets': [
{
'variables': {
@@ -48,7 +48,7 @@
},
},
],
- }, { # GENERATOR != ninja
+ }, { # GENERATOR == ninja or GENERATOR_FLAVOR == ninja
'targets': [
{
# The iOS frameworks being built for ios_web_shell_test require certs
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698