Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1844563002: S390: Fix Div64 sequence + DLGR simulation (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix Div64 sequence + DLGR simulation The CodeGenerator sequence for kS390_Div64 was incorrectly defaulting to the 32-bit divide sequence. That case has been fixed to use the proper 64-bit divide (DSGR). Fix bug in DLGR simulation where the register number was being used as operands instead of the values in those registers. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/6aa4cc4b9448022e833dff015a74c259e473cebb Cr-Commit-Position: refs/heads/master@{#35110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844563002/1
4 years, 8 months ago (2016-03-29 14:14:16 UTC) #2
JoranSiu
PTAL
4 years, 8 months ago (2016-03-29 14:14:21 UTC) #3
john.yan
lgtm
4 years, 8 months ago (2016-03-29 14:16:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 14:51:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844563002/1
4 years, 8 months ago (2016-03-29 15:04:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 15:06:10 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 15:07:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aa4cc4b9448022e833dff015a74c259e473cebb
Cr-Commit-Position: refs/heads/master@{#35110}

Powered by Google App Engine
This is Rietveld 408576698