Fix infobar arrow tip position on MD.

Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material Design mode.  The infobar arrow should not intersect the lock icon.

Review URL: https://codereview.chromium.org/1832023002

Cr-Commit-Position: refs/heads/master@{#383374}
(cherry picked from commit a614eb3fe5fba327416aac6ee990bda0f4a6654f)

Committed: https://chromium.googlesource.com/chromium/src/+/39df9e824ef7d9586232192a79100133778b876e

[Peter Kasting, 2016-03-29 03:00:53]

Description was changed from

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.

Review URL: https://codereview.chromium.org/1832023002

Cr-Commit-Position: refs/heads/master@{#383374}
(cherry picked from commit a614eb3fe5fba327416aac6ee990bda0f4a6654f)
==========

to

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.

Review URL: https://codereview.chromium.org/1832023002

Cr-Commit-Position: refs/heads/master@{#383374}
(cherry picked from commit a614eb3fe5fba327416aac6ee990bda0f4a6654f)

Committed:
https://chromium.googlesource.com/chromium/src/+/39df9e824ef7d9586232192a7910...
==========

[Peter Kasting, 2016-03-29 03:00:57]

Committed patchset #1 (id:1) manually as
39df9e824ef7d9586232192a79100133778b876e.