Fix infobar arrow tip position on MD.

Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material Design mode.  The infobar arrow should not intersect the lock icon.

Committed: https://crrev.com/a614eb3fe5fba327416aac6ee990bda0f4a6654f
Cr-Commit-Position: refs/heads/master@{#383374}

[Peter Kasting, 2016-03-25 08:40:52]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2016-03-25 08:43:05]

Description was changed from

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=
==========

to

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.
==========

[sky, 2016-03-25 15:37:34]

LGTM

[Peter Kasting, 2016-03-25 21:47:43]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-03-25 21:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832023002/1

[commit-bot: I haz the power, 2016-03-25 21:58:41]

Description was changed from

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.
==========

to

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.
==========

[commit-bot: I haz the power, 2016-03-25 21:58:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-25 22:00:09]

Description was changed from

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.
==========

to

==========
Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG=597921
TEST=On a brand new profile (so you get the "default browser" infobar on
startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material
Design mode.  The infobar arrow should not intersect the lock icon.

Committed: https://crrev.com/a614eb3fe5fba327416aac6ee990bda0f4a6654f
Cr-Commit-Position: refs/heads/master@{#383374}
==========

[commit-bot: I haz the power, 2016-03-25 22:00:10]

Patchset 1 (id:??) landed as
https://crrev.com/a614eb3fe5fba327416aac6ee990bda0f4a6654f
Cr-Commit-Position: refs/heads/master@{#383374}