ios/web/web_state/ui/crw_web_controller.mm - Issue 1844363004: [ios] Signal DidFinishLoad if target URL is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 1844363004: [ios] Signal DidFinishLoad if target URL is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 851a9adc829b388ffb0c268ddec85557beae80aa..7f7ccb516da9c4848a93dd7722978245e9a22ed5 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -1310,8 +1310,10 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

// Load the url. The UIWebView delegate callbacks take care of updating the

// session history and UI.

const GURL targetURL([self currentNavigationURL]);

- if (!targetURL.is_valid())

+ if (!targetURL.is_valid()) {

+ [self didFinishWithURL:targetURL loadSuccess:NO];

return;

+ }

// JavaScript should never be evaluated here. User-entered JS should be

// evaluated via stringByEvaluatingUserJavaScriptFromString.

« no previous file with comments | « no previous file | no next file » | no next file with comments »