Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/6ee20a04d40a4fa2ca9930325fa3173a0247817a
Cr-Commit-Position: refs/heads/master@{#384766}

[danakj, 2016-03-31 23:22:42]

Description was changed from

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
==========

to

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-31 23:23:10]

Description was changed from

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-31 23:23:11]

danakj@chromium.org changed reviewers:
+ pfeldman@chromium.org, piman@chromium.org

[danakj, 2016-03-31 23:23:21]

Description was changed from

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-31 23:23:47]

kbr: webgl
piman: content
chrishtr: public
pfeldman: TBR for test_runner

[danakj, 2016-03-31 23:23:52]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 23:24:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/1

[danakj, 2016-03-31 23:26:37]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 23:27:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/40001

[danakj, 2016-03-31 23:43:17]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 23:44:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/80001

[commit-bot: I haz the power, 2016-03-31 23:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 23:55:54]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[chrishtr, 2016-04-01 00:30:50]

lgtm

[Ken Russell (switch to Gerrit), 2016-04-01 00:43:54]

lgtm

[piman, 2016-04-01 00:44:09]

lgtm

https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
File components/test_runner/test_plugin.cc (right):

https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
components/test_runner/test_plugin.cc:178: blink::WebURL
url("chrome://TestPlugin::initialize");
nit: How about container->element().document().url()?
(just note, element() and document() can be null).

[danakj, 2016-04-01 00:45:23]

https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
File components/test_runner/test_plugin.cc (right):

https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
components/test_runner/test_plugin.cc:178: blink::WebURL
url("chrome://TestPlugin::initialize");
On 2016/04/01 00:44:09, piman wrote:
> nit: How about container->element().document().url()?
> (just note, element() and document() can be null).

I was hoping to never have a null URL anymore. Then maybe
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu...
would not be true?

[piman, 2016-04-01 00:49:37]

On Thu, Mar 31, 2016 at 5:45 PM, <danakj@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
> File components/test_runner/test_plugin.cc (right):
>
>
>
https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
> components/test_runner/test_plugin.cc:178: blink::WebURL
> url("chrome://TestPlugin::initialize");
> On 2016/04/01 00:44:09, piman wrote:
> > nit: How about container->element().document().url()?
> > (just note, element() and document() can be null).
>
> I was hoping to never have a null URL anymore. Then maybe
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu...
> would not be true?
>

It doesn't matter, the GPU side can't trust the renderer.


>
> https://codereview.chromium.org/1844363003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[piman, 2016-04-01 00:49:37]

On Thu, Mar 31, 2016 at 5:45 PM, <danakj@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
> File components/test_runner/test_plugin.cc (right):
>
>
>
https://codereview.chromium.org/1844363003/diff/80001/components/test_runner/...
> components/test_runner/test_plugin.cc:178: blink::WebURL
> url("chrome://TestPlugin::initialize");
> On 2016/04/01 00:44:09, piman wrote:
> > nit: How about container->element().document().url()?
> > (just note, element() and document() can be null).
>
> I was hoping to never have a null URL anymore. Then maybe
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu...
> would not be true?
>

It doesn't matter, the GPU side can't trust the renderer.


>
> https://codereview.chromium.org/1844363003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-01 00:50:00]

Woops, left behind references to WGC3D::Attributes, fixed them to all be
Platform::ContextAttributes. Also:

https://codereview.chromium.org/1844363003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h
(right):

https://codereview.chromium.org/1844363003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h:21:
WebGraphicsContext3D::Attributes toWebGraphicsContext3DAttributes(const
WebGLContextAttributes&, unsigned webGLVersion);
I changed this method name to "toPlatformContextAttributes()", and updated the
comment.

[danakj, 2016-04-01 01:10:03]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 01:10:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/140001

[haraken, 2016-04-01 01:11:09]

modules LGTM

[danakj, 2016-04-01 01:14:38]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 01:15:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/160001

[commit-bot: I haz the power, 2016-04-01 02:15:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 02:15:42]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[danakj, 2016-04-01 22:39:04]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 22:39:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/180001

[commit-bot: I haz the power, 2016-04-01 23:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 23:52:06]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-04-02 01:02:42]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-02 01:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org, piman@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1844363003/#ps180001
(title: "move-attributes: rebase")

[commit-bot: I haz the power, 2016-04-02 01:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844363003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844363003/180001

[commit-bot: I haz the power, 2016-04-02 01:08:53]

Description was changed from

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-02 01:08:55]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-02 01:10:45]

Description was changed from

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Also moves the url to be a parameter of the create method instead of
being an attribute, which lets us pass it by reference, which lets
us use a WebURL instead of doing conversions to/from WebStrings.

R=chrishtr@chromium.org, kbr@chromium.org, piman, pfeldman
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/6ee20a04d40a4fa2ca9930325fa3173a0247817a
Cr-Commit-Position: refs/heads/master@{#384766}
==========

[commit-bot: I haz the power, 2016-04-02 01:10:47]

Patchset 10 (id:??) landed as
https://crrev.com/6ee20a04d40a4fa2ca9930325fa3173a0247817a
Cr-Commit-Position: refs/heads/master@{#384766}