Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1844253002: Fix GS client breakage, remove offset hacks. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://github.com/luci/luci-go@subscriber-update
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix GS client breakage, remove offset hacks. A recent update to the Google Cloud Storage client library caused the existing hacks to add range support to break, resulting in an inability to read archived logs. Fortunately, the client library also added support for a range reader! This CL removes the offset hacks and switches over to the first-class range reader. BUG=chromium:597886 Committed: https://github.com/luci/luci-go/commit/fdfa04c6c456d06e5aad68069c79b05a6b4e71dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -97 lines) Patch
M common/gcloud/gs/gs.go View 4 chunks +31 lines, -40 lines 0 comments Download
D common/gcloud/gs/opts.go View 1 chunk +0 lines, -57 lines 0 comments Download
M server/logdog/storage/archive/storage.go View 3 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
iannucci
Yay less hacks! lgtm
4 years, 8 months ago (2016-03-31 17:56:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844253002/1
4 years, 8 months ago (2016-04-01 22:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844253002/1
4 years, 8 months ago (2016-04-01 22:25:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 22:35:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/fdfa04c6c456d06e5aad68069c79b05a6b4e71dd

Powered by Google App Engine
This is Rietveld 408576698