Use native Pub/Sub library primitives.

Use native Pub/Sub library primitives.

Remove the common/gcloud/pubsub/{subscriber/ackbuffer}, as those are now
built into the default Pub/Sub library via SubscriptionHandle.

Rewrite libraries that use those tools to use the new Pub/Sub library
structs instead.

BUG=chromium:597886
TEST=None

Committed: https://github.com/luci/luci-go/commit/d9cce0a1a2700c61bf5a984dd0f47ffbbbd13b3a

[dnj, 2016-03-29 18:42:41]

dnj@chromium.org changed reviewers:
+ estaab@chromium.org, iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2016-03-29 18:42:42]

PTAL. This uses the Google Cloud Pub/Sub library's (new) constructs instead of
our version of basically the same things.

[Vadim Sh., 2016-03-29 19:02:37]

lgtm

https://codereview.chromium.org/1838303002/diff/1/client/cmd/logdog_butler/ma...
File client/cmd/logdog_butler/main.go (right):

https://codereview.chromium.org/1838303002/diff/1/client/cmd/logdog_butler/ma...
client/cmd/logdog_butler/main.go:146: func (a *application)
authenticatedTokenSource(ctx context.Context) (oauth2.TokenSource, error) {
nit: just tokenSource(). It can't be "unauthenticated".

https://codereview.chromium.org/1838303002/diff/1/client/internal/logdog/butl...
File client/internal/logdog/butler/output/pubsub/pubsubOutput.go (right):

https://codereview.chromium.org/1838303002/diff/1/client/internal/logdog/butl...
client/internal/logdog/butler/output/pubsub/pubsubOutput.go:188: messageIDs, err
= o.Topic.Publish(o, messages...)
note: this can in theory produce duplicates (if error happens after backend
processed the request, but before client received a reply). I hope consumers are
smart enough to ignore duplicates (or it's not a big deal).

[dnj, 2016-03-29 19:27:21]

https://codereview.chromium.org/1838303002/diff/1/client/cmd/logdog_butler/ma...
File client/cmd/logdog_butler/main.go (right):

https://codereview.chromium.org/1838303002/diff/1/client/cmd/logdog_butler/ma...
client/cmd/logdog_butler/main.go:146: func (a *application)
authenticatedTokenSource(ctx context.Context) (oauth2.TokenSource, error) {
On 2016/03/29 19:02:37, Vadim Sh. wrote:
> nit: just tokenSource(). It can't be "unauthenticated".

Done.

https://codereview.chromium.org/1838303002/diff/1/client/internal/logdog/butl...
File client/internal/logdog/butler/output/pubsub/pubsubOutput.go (right):

https://codereview.chromium.org/1838303002/diff/1/client/internal/logdog/butl...
client/internal/logdog/butler/output/pubsub/pubsubOutput.go:188: messageIDs, err
= o.Topic.Publish(o, messages...)
On 2016/03/29 19:02:37, Vadim Sh. wrote:
> note: this can in theory produce duplicates (if error happens after backend
> processed the request, but before client received a reply). I hope consumers
are
> smart enough to ignore duplicates (or it's not a big deal).

That's a good point. They are (b/c they can also fail to ACK), but I hadn't
thought about this specific case.

[dnj, 2016-04-01 22:20:46]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-04-01 22:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1838303002/#ps20002
(title: "Use "Topic" instead of "NewTopic" ... don't want to create :)")

[commit-bot: I haz the power, 2016-04-01 22:20:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838303002/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838303002/20002

[commit-bot: I haz the power, 2016-04-01 22:24:55]

Description was changed from

==========
Use native Pub/Sub library primitives.

Remove the common/gcloud/pubsub/{subscriber/ackbuffer}, as those are now
built into the default Pub/Sub library via SubscriptionHandle.

Rewrite libraries that use those tools to use the new Pub/Sub library
structs instead.

BUG=chromium:597886
TEST=None
==========

to

==========
Use native Pub/Sub library primitives.

Remove the common/gcloud/pubsub/{subscriber/ackbuffer}, as those are now
built into the default Pub/Sub library via SubscriptionHandle.

Rewrite libraries that use those tools to use the new Pub/Sub library
structs instead.

BUG=chromium:597886
TEST=None

Committed:
https://github.com/luci/luci-go/commit/d9cce0a1a2700c61bf5a984dd0f47ffbbbd13b3a
==========

[commit-bot: I haz the power, 2016-04-01 22:24:56]

Committed patchset #4 (id:20002) as
https://github.com/luci/luci-go/commit/d9cce0a1a2700c61bf5a984dd0f47ffbbbd13b3a