Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm

Issue 1844243002: [CookieStore] Upgrading host-based deleting to predicate-based deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
diff --git a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
index 7e8472bab59069d7e1565f79f53d4c348328e9c9..d7e5a0efebb100e6257ac576f6c3ce5521efd8c9 100644
--- a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
+++ b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
@@ -126,11 +126,10 @@ void IOSChromeBrowsingDataRemover::set_removing(bool is_removing) {
}
void IOSChromeBrowsingDataRemover::Remove(int remove_mask) {
- RemoveImpl(remove_mask, GURL());
+ RemoveImpl(remove_mask);
}
-void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask,
- const GURL& remove_url) {
+void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask) {
DCHECK_CURRENTLY_ON(WebThread::UI);
set_removing(true);
remove_mask_ = remove_mask;
@@ -148,8 +147,6 @@ void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask,
browser_state_, ServiceAccessType::EXPLICIT_ACCESS);
if (history_service) {
std::set<GURL> restrict_urls;
- if (!remove_url.is_empty())
- restrict_urls.insert(remove_url);
web::RecordAction(UserMetricsAction("ClearBrowsingData_History"));
waiting_for_clear_history_ = true;
@@ -191,21 +188,19 @@ void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask,
waiting_for_clear_keyword_data_ = true;
} else if (keywords_model) {
keywords_model->RemoveAutoGeneratedForOriginBetween(
- remove_url, delete_begin_, delete_end_);
+ GURL(), delete_begin_, delete_end_);
}
}
// If the caller is removing history for all hosts, then clear ancillary
// historical information.
- if (remove_url.is_empty()) {
- // We also delete the list of recently closed tabs. Since these expire,
- // they can't be more than a day old, so we can simply clear them all.
- sessions::TabRestoreService* tab_service =
- IOSChromeTabRestoreServiceFactory::GetForBrowserState(browser_state_);
- if (tab_service) {
- tab_service->ClearEntries();
- tab_service->DeleteLastSession();
- }
+ // We also delete the list of recently closed tabs. Since these expire,
+ // they can't be more than a day old, so we can simply clear them all.
+ sessions::TabRestoreService* tab_service =
+ IOSChromeTabRestoreServiceFactory::GetForBrowserState(browser_state_);
+ if (tab_service) {
+ tab_service->ClearEntries();
+ tab_service->DeleteLastSession();
}
// The saved Autofill profiles and credit cards can include the origin from
@@ -240,7 +235,7 @@ void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask,
WebThread::PostTask(
WebThread::IO, FROM_HERE,
base::Bind(&IOSChromeBrowsingDataRemover::ClearCookiesOnIOThread,
- base::Unretained(this), main_context_getter_, remove_url));
+ base::Unretained(this), main_context_getter_));
// TODO(mkwst): If we're not removing passwords, then clear the 'zero-click'
// flag for all credentials in the password store.
@@ -454,22 +449,14 @@ void IOSChromeBrowsingDataRemover::OnClearedCookies(int num_deleted) {
}
void IOSChromeBrowsingDataRemover::ClearCookiesOnIOThread(
- const scoped_refptr<net::URLRequestContextGetter>& rq_context,
- const GURL& storage_url) {
+ const scoped_refptr<net::URLRequestContextGetter>& rq_context) {
DCHECK_CURRENTLY_ON(WebThread::IO);
net::CookieStore* cookie_store =
rq_context->GetURLRequestContext()->cookie_store();
- if (storage_url.is_empty()) {
- cookie_store->DeleteAllCreatedBetweenAsync(
- delete_begin_, delete_end_,
- base::Bind(&IOSChromeBrowsingDataRemover::OnClearedCookies,
- base::Unretained(this)));
- } else {
- cookie_store->DeleteAllCreatedBetweenForHostAsync(
- delete_begin_, delete_end_, storage_url,
- base::Bind(&IOSChromeBrowsingDataRemover::OnClearedCookies,
- base::Unretained(this)));
- }
+ cookie_store->DeleteAllCreatedBetweenAsync(
+ delete_begin_, delete_end_,
+ base::Bind(&IOSChromeBrowsingDataRemover::OnClearedCookies,
+ base::Unretained(this)));
}
void IOSChromeBrowsingDataRemover::ClearChannelIDsOnIOThread(
« no previous file with comments | « ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h ('k') | ios/net/cookies/cookie_store_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698