ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h - Issue 1844243002: [CookieStore] Upgrading host-based deleting to predicate-based deleting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h

Issue 1844243002: [CookieStore] Upgrading host-based deleting to predicate-based deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/storage_partition_impl_unittest.cc ('k') | ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h

diff --git a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h

index 0d5d9a3da6e42b0410209699dabed5b736fe8128..098528876e45ea03dcb919b9a31db14648284465 100644

--- a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h

+++ b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h

@@ -170,7 +170,7 @@ class IOSChromeBrowsingDataRemover {

// TODO(mkwst): The current implementation relies on unique (empty) origins to

// signal removal of all origins. Reconsider this behavior if/when we build

// a "forget this site" feature.

- void RemoveImpl(int remove_mask, const GURL& remove_url);

+ void RemoveImpl(int remove_mask);

// Notifies observers and deletes this object.

void NotifyAndDelete();

@@ -198,8 +198,7 @@ class IOSChromeBrowsingDataRemover {

// Invoked on the IO thread to delete cookies.

void ClearCookiesOnIOThread(

- const scoped_refptr<net::URLRequestContextGetter>& rq_context,

- const GURL& storage_url);

+ const scoped_refptr<net::URLRequestContextGetter>& rq_context);

// Invoked on the IO thread to delete channel IDs.

void ClearChannelIDsOnIOThread(