[CookieStore] Upgrading host-based deleting to predicate-based deleting.

[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
is only used by unittests and extensions. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing, and migrate
data_deleter.cc in extensions to use the predicate method.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586, 578162
Committed: https://crrev.com/faea244c3351a6e7f7f4939deb28646fef5e6bb8
Cr-Commit-Position: refs/heads/master@{#386262}

[dmurph, 2016-03-31 00:59:17]

Hello,

These are the cookie store changes, which remove the host-deletion path in favor
of the predicate-deletion path.

Daniel

[Mike West, 2016-04-01 07:40:51]

mkwst@chromium.org changed reviewers:
+ marq@chromium.org, torne@chromium.org

[Mike West, 2016-04-01 07:40:52]

Thank you for splitting this out. A few comments on //net/cookies. Perhaps marq@
could take a look at the //ios code, and torne@ could poke at the
//android_webview bits?

https://codereview.chromium.org/1844243002/diff/20001/content/browser/storage...
File content/browser/storage_partition_impl.cc (right):

https://codereview.chromium.org/1844243002/diff/20001/content/browser/storage...
content/browser/storage_partition_impl.cc:69:
cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
Why do we only clear host cookies here? I understand that it shouldn't be a
behavioral change, but I don't understand the current behavior.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:931: if (predicate.is_null()) {
This seems strange. If no predicate is provided, it seems like nothing would
match. Why would you match everything instead?

Either way, it would be nice if you added a test for this behavior.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1144: (delete_end.is_null() || cc->CreationDate()
< delete_end) &&
Please add a test for the null behavior.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:63: static CookiePredicate
CreatePredicateForHostCookies(const GURL& url);
This is only used by StoragePartition, right? Did you consider creating the
predicate there, rather than expanding CookieStore? I think I'd prefer to keep
CookieStore a bit leaner if there's not a good reason to put this here.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:167: // know what you are doing here so you don't
break the web.
This warning isn't very helpful. :) What should developers avoid doing to avoid
breaking the web?

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:1090: GURL
url_not_google("http://www.notgoogle.com");
Nit: You could use `this->http_foo_com_.url()` instead.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:1103: EXPECT_EQ(2,  // Deletes A=B, C=D, Y=Z
This doesn't delete `A=B`, does it?

It would be good to add some checks here to verify that the correct cookies were
removed.

It would also be good to verify the time semantics. That is, if a cookie that
matches the predicate doesn't fall within the created-between span, it shouldn't
be removed.

[marq (ping after 24h), 2016-04-01 08:28:13]

ios/ LGTM.

[Torne, 2016-04-01 11:36:08]

android_webview LGTM

[dmurph, 2016-04-01 23:16:46]

I removed some now-unnecessary tests.

https://codereview.chromium.org/1844243002/diff/20001/content/browser/storage...
File content/browser/storage_partition_impl.cc (right):

https://codereview.chromium.org/1844243002/diff/20001/content/browser/storage...
content/browser/storage_partition_impl.cc:69:
cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> Why do we only clear host cookies here? I understand that it shouldn't be a
behavioral change, but I don't understand the current behavior.

I have no idea. I suspect that we might be able to get rid of the host-specific
code path all together, but it's a little murky.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:931: if (predicate.is_null()) {
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> This seems strange. If no predicate is provided, it seems like nothing would
match. Why would you match everything instead?
> 
> Either way, it would be nice if you added a test for this behavior.

Ah, true. I'll do it that way.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:1144: (delete_end.is_null() || cc->CreationDate()
< delete_end) &&
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> Please add a test for the null behavior.

Done.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:63: static CookiePredicate
CreatePredicateForHostCookies(const GURL& url);
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> This is only used by StoragePartition, right? Did you consider creating the
predicate there, rather than expanding CookieStore? I think I'd prefer to keep
CookieStore a bit leaner if there's not a good reason to put this here.

Done.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:167: // know what you are doing here so you don't
break the web.
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> This warning isn't very helpful. :) What should developers avoid doing to
avoid breaking the web?

Changed.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:1090: GURL
url_not_google("http://www.notgoogle.com");
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> Nit: You could use `this->http_foo_com_.url()` instead.

done.

https://codereview.chromium.org/1844243002/diff/20001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:1103: EXPECT_EQ(2,  // Deletes A=B, C=D, Y=Z
On 2016/04/01 at 07:40:52, Mike West (OOO through 31st) wrote:
> This doesn't delete `A=B`, does it?
> 
> It would be good to add some checks here to verify that the correct cookies
were removed.
> 
> It would also be good to verify the time semantics. That is, if a cookie that
matches the predicate doesn't fall within the created-between span, it shouldn't
be removed.

Done.

[Mike West, 2016-04-02 05:12:40]

Thanks for taking another pass. //net/cookies LGTM.

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
File content/browser/storage_partition_impl.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
content/browser/storage_partition_impl.cc:76:
cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
Nit: Can you add a "TODO(mkwst): It's not clear whether removing host cookies is
the correct behavior. We might want to remove all domain-matching cookies
instead."? I'll look into this later.

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
File content/browser/storage_partition_impl_unittest.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
content/browser/storage_partition_impl_unittest.cc:949: }
Tiny nit: No {} for single-line clauses.

https://codereview.chromium.org/1844243002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster_unittest.cc:1273: 
Nit: Could you add a test for a null predicate here to verify that it doesn't
remove any cookies?

[dmurph, 2016-04-04 18:28:32]

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
File content/browser/storage_partition_impl.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
content/browser/storage_partition_impl.cc:76:
cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
On 2016/04/02 at 05:12:40, Mike West (OOO through 31st) wrote:
> Nit: Can you add a "TODO(mkwst): It's not clear whether removing host cookies
is the correct behavior. We might want to remove all domain-matching cookies
instead."? I'll look into this later.

Done.

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
File content/browser/storage_partition_impl_unittest.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/content/browser/storage...
content/browser/storage_partition_impl_unittest.cc:949: }
On 2016/04/02 at 05:12:40, Mike West (OOO through 31st) wrote:
> Tiny nit: No {} for single-line clauses.

Done.

https://codereview.chromium.org/1844243002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/1844243002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster_unittest.cc:1273: 
On 2016/04/02 at 05:12:40, Mike West (OOO through 31st) wrote:
> Nit: Could you add a test for a null predicate here to verify that it doesn't
remove any cookies?

Sure. This also is tested by the cookie_store_unittest.h (as it puts all those
tests in every backend), but I'll also test it here.

[dmurph, 2016-04-04 18:29:09]

Description was changed from

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
CookieStore::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
basically dead except for unittests. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162
==========

to

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
basically dead except for unittests. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162
==========

[dmurph, 2016-04-04 18:29:20]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-04-04 18:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org,
torne@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1844243002/#ps60001
(title: "Comments, ios fix")

[commit-bot: I haz the power, 2016-04-04 18:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844243002/60001

[commit-bot: I haz the power, 2016-04-04 18:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 18:45:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmurph, 2016-04-04 19:04:15]

Whoops, I still need brettw@ for approval of:
content/browser/storage_partition_impl.cc
content/browser/storage_partition_impl.h
content/browser/storage_partition_impl_unittest.cc
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm

[dmurph, 2016-04-04 23:14:32]

dmurph@chromium.org changed reviewers:
+ droger@chromium.org

[dmurph, 2016-04-04 23:14:33]

+droger for ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
+sievers for content/browser/*

Can you guys PTAL?

[droger, 2016-04-05 12:24:27]

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
(right):

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:135:
RemoveImpl(remove_mask, GURL());
It seems that the only call to RemoveImpl is here, with an empty GURL.

If we remove the dead code, it will actually remove the code you are changing in
this CL.

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:481: const
GURL& storage_url) {
storage_url is always empty (see comment above).
You can actually delete the code.

[dmurph, 2016-04-05 18:35:20]

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
(right):

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:135:
RemoveImpl(remove_mask, GURL());
On 2016/04/05 at 12:24:27, droger wrote:
> It seems that the only call to RemoveImpl is here, with an empty GURL.
> 
> If we remove the dead code, it will actually remove the code you are changing
in this CL.

Done.

https://codereview.chromium.org/1844243002/diff/80001/ios/chrome/browser/brow...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:481: const
GURL& storage_url) {
On 2016/04/05 at 12:24:27, droger wrote:
> storage_url is always empty (see comment above).
> You can actually delete the code.

Done.

[droger, 2016-04-05 19:15:38]

lgtm

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h
(right):

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h:202: const
GURL& storage_url);
Update this too.

[droger, 2016-04-05 19:17:30]

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
(right):

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:41:
#include "net/cookies/canonical_cookie.h"
This may not be needed.

[dmurph, 2016-04-05 22:15:54]

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h
(right):

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h:202: const
GURL& storage_url);
On 2016/04/05 at 19:15:38, droger wrote:
> Update this too.

Done.

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
(right):

https://codereview.chromium.org/1844243002/diff/100001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm:41:
#include "net/cookies/canonical_cookie.h"
On 2016/04/05 at 19:17:30, droger wrote:
> This may not be needed.

Done.

[dmurph, 2016-04-06 02:05:07]

dmurph@chromium.org changed reviewers:
+ sievers@chromium.org

[dmurph, 2016-04-06 02:05:07]

Whoops, for some reason I didn't add sievers@. Can you PTAL?

+sievers for content/browser/*

[dmurph, 2016-04-06 22:10:35]

dmurph@chromium.org changed reviewers:
+ devlinn.cronin@chromium.org, michaeln@chromium.org

[dmurph, 2016-04-06 22:10:36]

+michaeln for storage_partition_impl domain knowledge review
+devlin from the extension team, as the storage partition change effects their
data_deleter.cc, but shouldn't be a change from the current behavior.

Note: I'm going to be removing the origin-based deletion in
storage_parittion_impl for the predicate eventually, which will just have the
extensions's data_deleter.cc implement that predicate.

[dmurph, 2016-04-06 22:20:12]

dmurph@chromium.org changed reviewers:
+ rdcronin@google.com
- devlinn.cronin@chromium.org

[michaeln, 2016-04-06 22:50:47]

lgtm2

[michaeln, 2016-04-06 22:51:18]

On 2016/04/06 22:50:47, michaeln wrote:
lgtm 2

[dmurph, 2016-04-06 22:53:00]

dmurph@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- rdcronin@google.com

[no sievers, 2016-04-06 23:05:22]

lgtm since you chatted with devlin@, but please update the comment saying that
the codepath 'is only used for the extesions data deleter' in case this changes
behavior after all.

[dmurph, 2016-04-06 23:16:07]

Description was changed from

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
basically dead except for unittests. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162
==========

to

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
is only used by unittests and extensions. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing, and migrate
data_deleter.cc in extensions to use the predicate method.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162
==========

[dmurph, 2016-04-06 23:16:38]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-04-06 23:16:39]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
marq@chromium.org, torne@chromium.org, droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1844243002/#ps120001
(title: "ios fixes")

[commit-bot: I haz the power, 2016-04-06 23:17:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844243002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844243002/120001

[commit-bot: I haz the power, 2016-04-07 03:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:02:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmurph, 2016-04-07 20:14:31]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-04-07 20:14:31]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
michaeln@chromium.org, torne@chromium.org, marq@chromium.org,
mkwst@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1844243002/#ps140001
(title: "Added back old test data, fixing windows build error")

[commit-bot: I haz the power, 2016-04-07 20:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844243002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844243002/140001

[commit-bot: I haz the power, 2016-04-07 20:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:18:34]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmurph, 2016-04-07 20:31:50]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-04-07 20:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
michaeln@chromium.org, torne@chromium.org, marq@chromium.org,
mkwst@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1844243002/#ps160001
(title: "rebase")

[dmurph, 2016-04-07 20:31:56]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2016-04-07 20:35:24]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844243002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844243002/160001

[commit-bot: I haz the power, 2016-04-07 21:52:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:52:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmurph, 2016-04-08 23:31:14]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-04-08 23:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844243002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844243002/160001

[commit-bot: I haz the power, 2016-04-09 00:42:40]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-09 00:44:11]

Description was changed from

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
is only used by unittests and extensions. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing, and migrate
data_deleter.cc in extensions to use the predicate method.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162
==========

to

==========
[CookieStore] Upgrading host-based deleting to predicate-based deleting.
This patch removes the DeleteAllCreatedBetweenForHostAsync callpath in
favor of using a predicate. The current callers of the host version are
migrated to using the predicate, with the new
StoragePartitionImpl::CreatePredicateForHostCookies helper method.

It looks like the DeleteAllCreatedBetweenForHostAsync codepath is
is only used by unittests and extensions. The current client (storage
partition) is being changed in the following patch here:
https://codereview.chromium.org/1741123002
to expose the predicate functionality as well. After fully supporting
the filter functionality in our BrowsingDataRemover, we can remove all
notions of the single-host or single-origin based clearing, and migrate
data_deleter.cc in extensions to use the predicate method.

R=mkwst@chromium.org,brettw@chromium.org
BUG=589586,578162

Committed: https://crrev.com/faea244c3351a6e7f7f4939deb28646fef5e6bb8
Cr-Commit-Position: refs/heads/master@{#386262}
==========

[commit-bot: I haz the power, 2016-04-09 00:44:13]

Patchset 9 (id:??) landed as
https://crrev.com/faea244c3351a6e7f7f4939deb28646fef5e6bb8
Cr-Commit-Position: refs/heads/master@{#386262}