Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1844223004: Display a meaningfull error message when trying to capture a stack trace to a proxy. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Display a meaningfull error message when trying to capture a stack trace to a proxy. ... instead of RUNTIME_ASSERT pointing to V8 guts. BUG=chromium:599067 LOG=N Committed: https://crrev.com/c7ff5766cf9eb1b819029783fd7543c665f2a700 Cr-Commit-Position: refs/heads/master@{#35227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M src/isolate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/isolate.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-599067.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844223004/1
4 years, 8 months ago (2016-04-01 12:40:01 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-01 12:49:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 13:03:55 UTC) #7
Camillo Bruni
lgtm
4 years, 8 months ago (2016-04-04 08:09:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844223004/1
4 years, 8 months ago (2016-04-04 08:11:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 08:35:20 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 08:37:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7ff5766cf9eb1b819029783fd7543c665f2a700
Cr-Commit-Position: refs/heads/master@{#35227}

Powered by Google App Engine
This is Rietveld 408576698