Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/isolate.h

Issue 1844223004: Display a meaningfull error message when trying to capture a stack trace to a proxy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index bf4fc02224fd311a8f462143ed7cd5805b0aea52..e8d963db846855789005c49492cea28eb0755c70 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -682,12 +682,12 @@ class Isolate {
Handle<JSArray> CaptureCurrentStackTrace(
int frame_limit,
StackTrace::StackTraceOptions options);
- Handle<Object> CaptureSimpleStackTrace(Handle<JSObject> error_object,
+ Handle<Object> CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
Handle<Object> caller);
- MaybeHandle<JSObject> CaptureAndSetDetailedStackTrace(
- Handle<JSObject> error_object);
- MaybeHandle<JSObject> CaptureAndSetSimpleStackTrace(
- Handle<JSObject> error_object, Handle<Object> caller);
+ MaybeHandle<JSReceiver> CaptureAndSetDetailedStackTrace(
+ Handle<JSReceiver> error_object);
+ MaybeHandle<JSReceiver> CaptureAndSetSimpleStackTrace(
+ Handle<JSReceiver> error_object, Handle<Object> caller);
Handle<JSArray> GetDetailedStackTrace(Handle<JSObject> error_object);
Handle<JSArray> GetDetailedFromSimpleStackTrace(
Handle<JSObject> error_object);
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698