third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMeterElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLOutputElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

index 44ba54f9c9aba28d91217a9c56a23620ac5f5c86..d092b59a9f5d968704b96f863370b7f003214bff 100644

--- a/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

@@ -161,10 +161,10 @@ void HTMLOptGroupElement::accessKeyAction(bool)

void HTMLOptGroupElement::didAddUserAgentShadowRoot(ShadowRoot& root)

{

- DEFINE_STATIC_LOCAL(AtomicString, labelPadding, ("0 2px 1px 2px", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, labelMinHeight, ("1.2em", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(AtomicString, labelPadding, ("0 2px 1px 2px"));

+ DEFINE_STATIC_LOCAL(AtomicString, labelMinHeight, ("1.2em"));

RefPtrWillBeRawPtr<HTMLDivElement> label = HTMLDivElement::create(document());

- label->setAttribute(roleAttr, AtomicString("group", AtomicString::ConstructFromLiteral));

+ label->setAttribute(roleAttr, AtomicString("group"));

label->setAttribute(aria_labelAttr, AtomicString());

label->setInlineStyleProperty(CSSPropertyPadding, labelPadding);

label->setInlineStyleProperty(CSSPropertyMinHeight, labelMinHeight);