third_party/WebKit/Source/core/html/HTMLMeterElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp b/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

index ab3ddba7f302cedf4ad2ccd9aa0877ea1a78d6f3..f205a63a856888d9aa0c5a4a05b071a68024a3c7 100644

--- a/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

@@ -194,11 +194,11 @@ void HTMLMeterElement::didAddUserAgentShadowRoot(ShadowRoot& root)

ASSERT(!m_value);

RefPtrWillBeRawPtr<HTMLDivElement> inner = HTMLDivElement::create(document());

- inner->setShadowPseudoId(AtomicString("-webkit-meter-inner-element", AtomicString::ConstructFromLiteral));

+ inner->setShadowPseudoId(AtomicString("-webkit-meter-inner-element"));

root.appendChild(inner);

RefPtrWillBeRawPtr<HTMLDivElement> bar = HTMLDivElement::create(document());

- bar->setShadowPseudoId(AtomicString("-webkit-meter-bar", AtomicString::ConstructFromLiteral));

+ bar->setShadowPseudoId(AtomicString("-webkit-meter-bar"));

m_value = HTMLDivElement::create(document());

updateValueAppearance(0);

@@ -209,9 +209,9 @@ void HTMLMeterElement::didAddUserAgentShadowRoot(ShadowRoot& root)

void HTMLMeterElement::updateValueAppearance(double percentage)

{

- DEFINE_STATIC_LOCAL(AtomicString, optimumPseudoId, ("-webkit-meter-optimum-value", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, suboptimumPseudoId, ("-webkit-meter-suboptimum-value", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, evenLessGoodPseudoId, ("-webkit-meter-even-less-good-value", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(AtomicString, optimumPseudoId, ("-webkit-meter-optimum-value"));

+ DEFINE_STATIC_LOCAL(AtomicString, suboptimumPseudoId, ("-webkit-meter-suboptimum-value"));

+ DEFINE_STATIC_LOCAL(AtomicString, evenLessGoodPseudoId, ("-webkit-meter-even-less-good-value"));

m_value->setInlineStyleProperty(CSSPropertyWidth, percentage, CSSPrimitiveValue::UnitType::Percentage);

switch (getGaugeRegion()) {