third_party/WebKit/Source/core/html/HTMLButtonElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAudioElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

index 44a97178edc587d66835b7fa6c013f9020a511bd..2e500c180dbad2461ab4c8cdfd493fe25532c258 100644

--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

@@ -63,15 +63,15 @@ const AtomicString& HTMLButtonElement::formControlType() const

{

switch (m_type) {

case SUBMIT: {

- DEFINE_STATIC_LOCAL(const AtomicString, submit, ("submit", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, submit, ("submit"));

return submit;

}

case BUTTON: {

- DEFINE_STATIC_LOCAL(const AtomicString, button, ("button", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, button, ("button"));

return button;

}

case RESET: {

- DEFINE_STATIC_LOCAL(const AtomicString, reset, ("reset", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, reset, ("reset"));

return reset;

}