Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 LayoutObject* HTMLButtonElement::createLayoutObject(const ComputedStyle&) 57 LayoutObject* HTMLButtonElement::createLayoutObject(const ComputedStyle&)
58 { 58 {
59 return new LayoutButton(this); 59 return new LayoutButton(this);
60 } 60 }
61 61
62 const AtomicString& HTMLButtonElement::formControlType() const 62 const AtomicString& HTMLButtonElement::formControlType() const
63 { 63 {
64 switch (m_type) { 64 switch (m_type) {
65 case SUBMIT: { 65 case SUBMIT: {
66 DEFINE_STATIC_LOCAL(const AtomicString, submit, ("submit", AtomicString: :ConstructFromLiteral)); 66 DEFINE_STATIC_LOCAL(const AtomicString, submit, ("submit"));
67 return submit; 67 return submit;
68 } 68 }
69 case BUTTON: { 69 case BUTTON: {
70 DEFINE_STATIC_LOCAL(const AtomicString, button, ("button", AtomicString: :ConstructFromLiteral)); 70 DEFINE_STATIC_LOCAL(const AtomicString, button, ("button"));
71 return button; 71 return button;
72 } 72 }
73 case RESET: { 73 case RESET: {
74 DEFINE_STATIC_LOCAL(const AtomicString, reset, ("reset", AtomicString::C onstructFromLiteral)); 74 DEFINE_STATIC_LOCAL(const AtomicString, reset, ("reset"));
75 return reset; 75 return reset;
76 } 76 }
77 } 77 }
78 78
79 ASSERT_NOT_REACHED(); 79 ASSERT_NOT_REACHED();
80 return emptyAtom; 80 return emptyAtom;
81 } 81 }
82 82
83 bool HTMLButtonElement::isPresentationAttribute(const QualifiedName& name) const 83 bool HTMLButtonElement::isPresentationAttribute(const QualifiedName& name) const
84 { 84 {
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 222 }
223 223
224 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint) 224 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint)
225 { 225 {
226 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint); 226 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint);
227 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr); 227 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr);
228 return request; 228 return request;
229 } 229 }
230 230
231 } // namespace blink 231 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698