Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: impl/memory/gkvlite_iter_test.go

Issue 1844183003: Don't filter "Stop" error in raw interface. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Count filter doesn't count Stop as error. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/memory/gkvlite_iter.go ('k') | impl/prod/raw_datastore.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/memory/gkvlite_iter_test.go
diff --git a/impl/memory/gkvlite_iter_test.go b/impl/memory/gkvlite_iter_test.go
index fe87ac57bd3d63576084ec22284432b6d3db804b..936bb3f4aa03075787fef78a98639d9017e68b9f 100644
--- a/impl/memory/gkvlite_iter_test.go
+++ b/impl/memory/gkvlite_iter_test.go
@@ -214,7 +214,7 @@ func TestMultiIteratorSimple(t *testing.T) {
So(readNum(suffix), ShouldEqual, vals[i][1])
i++
return nil
- }), ShouldBeNil)
+ }), shouldBeSuccessful)
So(i, ShouldEqual, 3)
})
@@ -229,7 +229,7 @@ func TestMultiIteratorSimple(t *testing.T) {
i := 0
So(multiIterate(defs, func(suffix []byte) error {
panic("never")
- }), ShouldBeNil)
+ }), shouldBeSuccessful)
So(i, ShouldEqual, 0)
})
@@ -249,7 +249,7 @@ func TestMultiIteratorSimple(t *testing.T) {
So(readNum(suffix), ShouldEqual, expect[i])
i++
return nil
- }), ShouldBeNil)
+ }), shouldBeSuccessful)
})
Convey("Can stop early", func() {
@@ -263,7 +263,7 @@ func TestMultiIteratorSimple(t *testing.T) {
So(readNum(suffix), ShouldEqual, vals[i][1])
i++
return nil
- }), ShouldBeNil)
+ }), shouldBeSuccessful)
So(i, ShouldEqual, 5)
i = 0
@@ -271,7 +271,7 @@ func TestMultiIteratorSimple(t *testing.T) {
So(readNum(suffix), ShouldEqual, vals[i][1])
i++
return datastore.Stop
- }), ShouldBeNil)
+ }), shouldBeSuccessful)
So(i, ShouldEqual, 1)
})
« no previous file with comments | « impl/memory/gkvlite_iter.go ('k') | impl/prod/raw_datastore.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698