impl/memory/gkvlite_iter.go - Issue 1844183003: Don't filter "Stop" error in raw interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/gkvlite_iter.go

Issue 1844183003: Don't filter "Stop" error in raw interface. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Count filter doesn't count Stop as error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: impl/memory/gkvlite_iter.go

diff --git a/impl/memory/gkvlite_iter.go b/impl/memory/gkvlite_iter.go

index 0569d1412e18a49637efc25800986e7e7394fd5f..43cc46345fae93e17df5d471f6e14a67ddd35329 100644

--- a/impl/memory/gkvlite_iter.go

+++ b/impl/memory/gkvlite_iter.go

@@ -8,7 +8,6 @@ import (

"bytes"

"sync"

- "github.com/luci/gae/service/datastore"

"github.com/luci/gae/service/datastore/serialize"

"github.com/luci/gkvlite"

)

@@ -100,9 +99,6 @@ func multiIterate(defs []*iterDefinition, cb func(suffix []byte) error) error {

}

if err := cb(suffix); err != nil {

- if err == datastore.Stop {

- return nil

- }

return err

}

suffix = nil

« no previous file with comments | « impl/memory/datastore_query_execution_test.go ('k') | impl/memory/gkvlite_iter_test.go » ('j') | no next file with comments »