Mojom compiler frontend: Populate the declaration_order field for Methods.

Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order field for MojomMethod in the intermediate representation even though the infrastructure is there to do that. We rectify this here. This simply allows the generators to write methods into the generated source in original lexical order if they wish to do so.

We do not yet consume this in the old backend. (Currently the generators in the old backend are writing the methods in ordinal order. This differs from what version 1 of the compiler used to do I think.)

R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/e0873846fc61eae0b813cc0c87c8009fda9f2aab

[rudominer, 2016-03-30 21:46:38]

Description was changed from

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

BUG=
==========

to

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order
field for MojomMethod in the intermediate representation even though the
infrastructure is there to do that. We rectify this here. This simply allows the
generators to generate the methods in original lexical order if they wish to do
so.

We do not yet consume this in the old backend. (Currently the old backend is
generating the methods in ordinal order.)
==========

[rudominer, 2016-03-30 21:48:11]

Description was changed from

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order
field for MojomMethod in the intermediate representation even though the
infrastructure is there to do that. We rectify this here. This simply allows the
generators to generate the methods in original lexical order if they wish to do
so.

We do not yet consume this in the old backend. (Currently the old backend is
generating the methods in ordinal order.)
==========

to

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order
field for MojomMethod in the intermediate representation even though the
infrastructure is there to do that. We rectify this here. This simply allows the
generators to write methods into the generated source in original lexical order
if they wish to do so.

We do not yet consume this in the old backend. (Currently the generators in the
old backend are writing the methods in ordinal order. This differs from what
version 1 of the compiler used to do I think.)
==========

[rudominer, 2016-03-30 22:54:32]

rudominer@chromium.org changed reviewers:
+ alexander.orlov@loxal.net, vardhan@google.com

[rudominer, 2016-03-30 22:54:32]

Vardhan, Alex, ptal.

[Alex, 2016-03-30 23:41:58]

lgtm

[rudominer, 2016-03-30 23:45:11]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org
- alexander.orlov@loxal.net

[rudominer, 2016-03-30 23:45:12]

Hi Alexander Orlov. I apologize-- I actually sent this to you by accident. I
meant to send this to azani@chromium.org But I appreciate you taking the time to
look at it and give me an lgtm!

[azani, 2016-03-31 18:29:37]

lgtm

[rudominer, 2016-03-31 18:30:57]

Description was changed from

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order
field for MojomMethod in the intermediate representation even though the
infrastructure is there to do that. We rectify this here. This simply allows the
generators to write methods into the generated source in original lexical order
if they wish to do so.

We do not yet consume this in the old backend. (Currently the generators in the
old backend are writing the methods in ordinal order. This differs from what
version 1 of the compiler used to do I think.)
==========

to

==========
Mojom compiler frontend: Populate the declaration_order field for Methods.

This is a pretty minor change. We have not been populating the declaration_order
field for MojomMethod in the intermediate representation even though the
infrastructure is there to do that. We rectify this here. This simply allows the
generators to write methods into the generated source in original lexical order
if they wish to do so.

We do not yet consume this in the old backend. (Currently the generators in the
old backend are writing the methods in ordinal order. This differs from what
version 1 of the compiler used to do I think.)

R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/e0873846fc61eae0b813cc0c87c...
==========

[rudominer, 2016-03-31 18:30:59]

Committed patchset #2 (id:20001) manually as
e0873846fc61eae0b813cc0c87c8009fda9f2aab (presubmit successful).