mojom/mojom_parser/mojom/user_defined_types.go - Issue 1844103002: Mojom compiler frontend: Populate the declaration_order field for Methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/mojom/user_defined_types.go

Issue 1844103002: Mojom compiler frontend: Populate the declaration_order field for Methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Don't change mojom_translator.py in this cl. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 ('k') | mojom/mojom_parser/serialization/serialization_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojom/mojom_parser/mojom/user_defined_types.go

diff --git a/mojom/mojom_parser/mojom/user_defined_types.go b/mojom/mojom_parser/mojom/user_defined_types.go

index 1c892f7d50513e749b870b1ba7c02e6ee2417b32..18b52f2d283e037773848c6649d36be2e4a4d94a 100644

--- a/mojom/mojom_parser/mojom/user_defined_types.go

+++ b/mojom/mojom_parser/mojom/user_defined_types.go

@@ -745,6 +745,7 @@ func (i *MojomInterface) AddMethod(method *MojomMethod) DuplicateNameError {

return err

}

i.methodsByName[method.simpleName] = method

+ method.lexicalPosition = int32(len(i.methodsByLexicalOrder))

i.methodsByLexicalOrder = append(i.methodsByLexicalOrder, method)

i.DeclaredObjects = append(i.DeclaredObjects, method)

return nil